Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM-based Compiler #578

Merged
merged 31 commits into from
Aug 12, 2023
Merged

LLVM-based Compiler #578

merged 31 commits into from
Aug 12, 2023

Conversation

ctiedt
Copy link
Collaborator

@ctiedt ctiedt commented Jul 20, 2023

Closes: #298

This PR introduces an initial LLVM-based compiler for Candy using the inkwell crate. While the compiler does not support all instructions yet, simple examples are already runnable.

@ctiedt ctiedt requested review from MarcelGarus and JonasWanke July 20, 2023 21:23
@jwbot jwbot added the P: Compiler: CLI Package: Candy's command-line interface label Jul 20, 2023
JonasWanke
JonasWanke requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still working on compiler/backend_inkwell/src/lib.rs

compiler/backend_inkwell/README.md Outdated Show resolved Hide resolved
compiler/backend_inkwell/Cargo.toml Outdated Show resolved Hide resolved
compiler/backend_inkwell/Cargo.toml Outdated Show resolved Hide resolved
compiler/backend_inkwell/Cargo.toml Outdated Show resolved Hide resolved
compiler/backend_inkwell/Cargo.toml Outdated Show resolved Hide resolved
compiler/cli/src/inkwell.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/candy_rt/candy_rt.c Outdated Show resolved Hide resolved
compiler/backend_inkwell/candy_rt/candy_rt.c Outdated Show resolved Hide resolved
compiler/backend_inkwell/candy_rt/candy_rt.c Outdated Show resolved Hide resolved
compiler/backend_inkwell/candy_rt/candy_rt.c Outdated Show resolved Hide resolved
JonasWanke
JonasWanke requested changes Aug 10, 2023
View reviewed changes
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Show resolved Hide resolved
compiler/backend_inkwell/Cargo.toml Outdated Show resolved Hide resolved
compiler/backend_inkwell/candy_rt/candy_rt.c Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
@jwbot jwbot added the P: Compiler: Frontend Package: The compiler frontend label Aug 10, 2023
@JonasWanke JonasWanke added the T: Feature Type: New Features label Aug 10, 2023
@ctiedt ctiedt marked this pull request as ready for review August 10, 2023 18:57
@jwbot jwbot enabled auto-merge August 10, 2023 18:57
@ctiedt ctiedt requested a review from JonasWanke August 10, 2023 19:47
JonasWanke
JonasWanke requested changes Aug 12, 2023
View reviewed changes
Copy link
Member

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and please add the new crate to /compiler.code-workspace, maybe below the VM

compiler/backend_inkwell/candy_runtime/candy_builtin.c Outdated Show resolved Hide resolved
compiler/backend_inkwell/candy_runtime/candy_builtin.c Show resolved Hide resolved
compiler/cli/src/inkwell.rs Outdated Show resolved Hide resolved
compiler/cli/src/inkwell.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
compiler/backend_inkwell/src/lib.rs Outdated Show resolved Hide resolved
@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: f25d852..3b09a8f

@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: f25d852..75b12cf

@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: f25d852..a1fb6ea

@jwbot jwbot merged commit 87fecea into main Aug 12, 2023
@jwbot jwbot deleted the inkwell-compiler branch August 12, 2023 10:07
@JonasWanke JonasWanke mentioned this pull request Aug 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke approved these changes

@MarcelGarus MarcelGarus Awaiting requested review from MarcelGarus

Assignees

@ctiedt ctiedt

Labels
P: Compiler: CLI Package: Candy's command-line interface P: Compiler: Frontend Package: The compiler frontend T: Feature Type: New Features
Projects
🍭 Candy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support LLVM
3 participants
@ctiedt @jwbot @JonasWanke