Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROTOCOL_SSLv23
is an alias toPROTOCOL_TLS
since Python 3.6.PROTOCOL_TLS
is deprecated since Python 3.10.PROTOCOL_TLS_CLIENT
has been introduced in Python 3.6 and should be used for client-side contexts.This patch uses
PROTOCOL_TLS_CLIENT
instead ofPROTOCOL_SSLv23
.There is no need to use
OP_NO_SSLv2
andOP_NO_SSLv3
flags explicitly now; SSLContext disables these by default.The flag
PROTOCOL_TLS_CLIENT
enables thecheck_hostname
by default. For insecure contexts we need to disable this flag explicitly.