Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add methods for extracting data from fusion callers #230

Merged
merged 23 commits into from
Jan 27, 2025
Merged

Conversation

jarbesfeld
Copy link
Contributor

@jarbesfeld jarbesfeld commented Jan 17, 2025

closes #229

Some points:

  • I updated one of the attributes in the Arriba class and added a new attribute for the Enfusion class
  • For the new fixtures/ folder, I re-used the test datasets when applicable from here. For the fusion callers that did not have test data available, I either downloaded the one-row dataset from the fusion caller repos or created my own test one-row dataset
  • It's possible the extraction methods could be refactored to remove some duplicate code

@jarbesfeld jarbesfeld added the priority:medium Medium priority label Jan 17, 2025
@jarbesfeld jarbesfeld self-assigned this Jan 17, 2025
@jarbesfeld jarbesfeld requested a review from korikuzma January 17, 2025 18:22
@jarbesfeld jarbesfeld added enhancement New feature or request stale-exempt labels Jan 17, 2025
@jarbesfeld jarbesfeld marked this pull request as ready for review January 17, 2025 18:22
Base automatically changed from issue-227 to main January 23, 2025 14:28
src/fusor/extract.py Outdated Show resolved Hide resolved
src/fusor/extract.py Outdated Show resolved Hide resolved
src/fusor/extract.py Outdated Show resolved Hide resolved
@jarbesfeld jarbesfeld requested a review from korikuzma January 23, 2025 20:13
src/fusor/extract.py Outdated Show resolved Hide resolved
src/fusor/extract.py Outdated Show resolved Hide resolved
src/fusor/extract.py Outdated Show resolved Hide resolved
@jarbesfeld jarbesfeld requested a review from korikuzma January 23, 2025 22:23
@jarbesfeld
Copy link
Contributor Author

@korikuzma I moved the extraction methods directly into the fusion caller classes, so the extraction methods can be directly accessed from the classes

src/fusor/fusion_caller_models.py Outdated Show resolved Hide resolved
src/fusor/fusion_caller_models.py Show resolved Hide resolved
@jarbesfeld jarbesfeld requested a review from korikuzma January 24, 2025 16:32
src/fusor/harvester.py Outdated Show resolved Hide resolved
src/fusor/harvester.py Outdated Show resolved Hide resolved
src/fusor/harvester.py Outdated Show resolved Hide resolved
src/fusor/harvester.py Outdated Show resolved Hide resolved
@jarbesfeld jarbesfeld requested a review from korikuzma January 27, 2025 14:59
@jarbesfeld jarbesfeld changed the title feat: Add methods for extracting data from fusion callers feat!: Add methods for extracting data from fusion callers Jan 27, 2025
@jarbesfeld jarbesfeld merged commit 93f9eec into main Jan 27, 2025
10 checks passed
@jarbesfeld jarbesfeld deleted the issue-229 branch January 27, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority stale-exempt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extraction code for processing fusion caller data
2 participants