-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add methods for extracting data from fusion callers #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
requested changes
Jan 23, 2025
korikuzma
reviewed
Jan 23, 2025
@korikuzma I moved the extraction methods directly into the fusion caller classes, so the extraction methods can be directly accessed from the classes |
korikuzma
requested changes
Jan 24, 2025
korikuzma
reviewed
Jan 24, 2025
korikuzma
requested changes
Jan 27, 2025
korikuzma
approved these changes
Jan 27, 2025
korikuzma
reviewed
Jan 27, 2025
jarbesfeld
changed the title
feat: Add methods for extracting data from fusion callers
feat!: Add methods for extracting data from fusion callers
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #229
Some points:
Arriba
class and added a new attribute for theEnfusion
classfixtures/
folder, I re-used the test datasets when applicable from here. For the fusion callers that did not have test data available, I either downloaded the one-row dataset from the fusion caller repos or created my own test one-row dataset