-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup logging #2555
Merged
Merged
Fix setup logging #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
fix-settup-logging
branch
2 times, most recently
from
December 12, 2024 07:32
a0d7ea4
to
651fca9
Compare
sbrunner
added
backport master
Backport the pull request to the 'master' branch
and removed
backport 6.1
Backport the pull request to the '6.1' branch
labels
Dec 12, 2024
arnaud-morvan
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
To avoid: ``` File "/usr/lib/python3.12/logging/__init__.py", line 1539, in info self._log(INFO, msg, args, **kwargs) File "/usr/lib/python3.12/logging/__init__.py", line 1684, in _log self.handle(record) File "/usr/lib/python3.12/logging/__init__.py", line 1700, in handle self.callHandlers(record) File "/venv/lib/python3.12/site-packages/sentry_sdk/integrations/logging.py", line 98, in sentry_patched_callhandlers return old_callhandlers(self, record) Message: '[%s] %r' Arguments: ('cached since 570.4s ago', {'status': 'ERROR', 'status_1': 'PENDING', 'created_at_1': datetime.datetime(2024, 12, 8, 16, 4, 28, 898425, tzinfo=datetime.timezone.utc)}) --- Logging error --- Traceback (most recent call last): File "/usr/lib/python3.12/logging/__init__.py", line 1163, in emit stream.write(msg + self.terminator) ^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'write' ```
sbrunner
force-pushed
the
fix-settup-logging
branch
from
January 6, 2025 12:21
651fca9
to
494482f
Compare
From the artifact of the previous workflow run
c2c-bot-gis-ci-2
removed
the
backport master
Backport the pull request to the 'master' branch
label
Jan 6, 2025
Note that now I get with in
|
args is effectively not working, see: https://github.com/camptocamp/c2cwsgiutils/releases/tag/6.1.0 :-) |
thank @sbrunner for the tip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid: