Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the background color from the generated image #2211

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Apr 8, 2024

Nice for image in dark mode

@sbrunner sbrunner force-pushed the use-background-color branch from 3b3494b to 5311927 Compare April 8, 2024 14:25
@sbrunner sbrunner marked this pull request as ready for review April 8, 2024 14:44
Copy link
Member

@danduk82 danduk82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, I cannot anticipate which side effects this might have with flat histograms, but let's go...

@sbrunner
Copy link
Member Author

Normally no possible side effect, it's used only on image generation during the test :-)

@sbrunner sbrunner merged commit f50825c into 6.0 Apr 10, 2024
1 check passed
@sbrunner sbrunner deleted the use-background-color branch April 10, 2024 11:47
@geo-ghci-int geo-ghci-int bot added this to the 6.0.8 milestone Apr 11, 2024
@sbrunner sbrunner added backport master Backport the pull request to the 'master' branch backport 6.1 Backport the pull request to the '6.1' branch labels Jan 16, 2025
@c2c-bot-gis-ci-2
Copy link

Error on backporting to branch master, see Docker Hub actions for more information.

@c2c-bot-gis-ci-2 c2c-bot-gis-ci-2 removed the backport master Backport the pull request to the 'master' branch label Jan 16, 2025
@c2c-bot-gis-ci-2 c2c-bot-gis-ci-2 removed the backport 6.1 Backport the pull request to the '6.1' branch label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants