chore: Rename tool call instances #1492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Wendong-Fan
changed the title
Wendong-Fan
reviewed
Jan 26, 2025
Wendong-Fan
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Thanks @JINO-ROHIT for the contribution! Left some comments below also added one commit here based on the review:8449737 , please review the change and let me know if there's anything we could discuss further~
camel/agents/chat_agent.py
Outdated
| func_name = choice.message.tool_calls[0].function.name | ||
| tool_name = choice.message.tool_calls[0].function.name |
There was a problem hiding this comment.
here I think we need to keep it as func_name as the value is taken from choice.message.tool_calls[0].function.name
camel/agents/chat_agent.py
Outdated
| func_name = choice.message.tool_calls[0].function.name | ||
| tool_name = choice.message.tool_calls[0].function.name |
| "from camel.agents.chat_agent import FunctionCallingRecord\n", | ||
| "from camel.agents.chat_agent import ToolCallingRecord\n", |
There was a problem hiding this comment.
without updating camel's version, we shouldn't directly make change to the output content of cookbooks
Wendong-Fan
approved these changes
Feb 4, 2025
|
ahh thanks making the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #1470
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
I have closely gone through #1424 although I mightve missed a few instances since it was a massive PR and made similar renames required.
Also i dont have an API Key, is there a way I can test my changes, and rerun examples notebooks to remove the saved output pointing to older functioncall.