Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update anthropic #1392

Merged
merged 5 commits into from
Jan 4, 2025
Merged

fix: update anthropic #1392

merged 5 commits into from
Jan 4, 2025

Conversation

Asher-hss
Copy link
Collaborator

Description

#1356

Motivation and Context

[Why is this change required? What problem does it solve?

#1356

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Asher-hss Asher-hss marked this pull request as draft January 3, 2025 10:09
@Asher-hss Asher-hss self-assigned this Jan 3, 2025
@Wendong-Fan Wendong-Fan changed the title update anthropic fix: update anthropic Jan 3, 2025
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Jan 3, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 20 milestone Jan 3, 2025
@Wendong-Fan Wendong-Fan linked an issue Jan 3, 2025 that may be closed by this pull request
3 tasks
@Wendong-Fan Wendong-Fan modified the milestones: Sprint 20, Sprint 19 Jan 3, 2025
pyproject.toml Outdated
@@ -48,7 +48,7 @@ litellm = { version = "^1.38.1", optional = true }
google-generativeai = { version = "^0.6.0", optional = true }
mistralai = { version = "^1.1.0", optional = true }
reka-api = { version = "^3.0.8", optional = true }
anthropic = { version = "^0.40.0", optional = true }
anthropic = { version = "0.42.0", optional = true }
Copy link
Member

@Wendong-Fan Wendong-Fan Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ^will fix the version, we'd better don't do that
also always remember to run poetry lock if you made change to the toml file

Suggested change
anthropic = { version = "0.42.0", optional = true }
anthropic = { version = "^0.42.0", optional = true }

@Wendong-Fan Wendong-Fan marked this pull request as ready for review January 4, 2025 18:15
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Asher-hss , added one more commit 3758c89 to fix, feel free to check

@Wendong-Fan Wendong-Fan merged commit fdf08dd into master Jan 4, 2025
6 checks passed
@Wendong-Fan Wendong-Fan deleted the Claude_fix branch January 4, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] "role_playing_with_claude" cannot execute properly.
2 participants