Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect role assigning in rewardmodelfilter #1390

Merged

Conversation

AveryYay
Copy link
Collaborator

@AveryYay AveryYay commented Jan 3, 2025

Description

Added prompt to RewardModelFilter

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@AveryYay AveryYay self-assigned this Jan 3, 2025
@AveryYay AveryYay linked an issue Jan 3, 2025 that may be closed by this pull request
3 tasks
@AveryYay AveryYay changed the title Bug/ncorrect role assigning in rewardmodelfilter Bug/incorrect role assigning in rewardmodelfilter Jan 3, 2025
@AveryYay AveryYay changed the title Bug/incorrect role assigning in rewardmodelfilter Bug: incorrect role assigning in rewardmodelfilter Jan 3, 2025
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Jan 3, 2025
@Wendong-Fan Wendong-Fan changed the title Bug: incorrect role assigning in rewardmodelfilter fix: incorrect role assigning in rewardmodelfilter Jan 3, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 20 milestone Jan 3, 2025
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AveryYay !

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Wendong-Fan Wendong-Fan merged commit e262fd1 into master Jan 3, 2025
4 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the bug/ncorrect-role-assigning-in-rewardmodelfilter branch January 3, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect role assigning in RewardModelFilter
3 participants