Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace DataTable implementation #18785

Conversation

eunjae-lee
Copy link
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 7:51pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 7:51pm

Copy link

linear bot commented Jan 21, 2025

Copy link

socket-security bot commented Jan 21, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network 0 549 kB panva

🚮 Removed packages: npm/@formkit/[email protected], npm/[email protected]

View full report↗︎

@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5021-replace-base-table-components-with-origin-ui branch from 9a1d51a to 5448982 Compare January 21, 2025 19:50
@eunjae-lee
Copy link
Contributor Author

This PR was meant to replace the implementation of DataTable by putting all the examples of Origin UI together. However, there are many CSS issues once all the necessary features are combined 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants