Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add credential check for CRM credentials #18774

Closed
wants to merge 7 commits into from

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Jan 21, 2025

What does this PR do?

  • Ensures that the credential that is being used to create CRM events belongs to the organizer or team

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@joeauyeung joeauyeung requested a review from a team as a code owner January 21, 2025 04:06
@graphite-app graphite-app bot requested a review from a team January 21, 2025 04:06
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 21, 2025
@dosubot dosubot bot added the crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid label Jan 21, 2025
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 4:15am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 4:15am

Copy link

graphite-app bot commented Jan 21, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/21/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't work when you install a CRM for an org.

@github-actions github-actions bot marked this pull request as draft January 21, 2025 07:05
@joeauyeung joeauyeung closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants