fix: Multiple rr-hosts combine to create erroneous availability #18772
+324
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
emrysal
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
emrysal
changed the title
…t returns the same slots twice.
emrysal
commented
Jan 22, 2025
| expect(result).toHaveLength(6); | ||
| }); | ||
|
|
||
| it("can merge multiple time slot groups when multiple date ranges are given that overlap", async () => { |
There was a problem hiding this comment.
Overlapping time slots weren't possible before as date ranges were merged, even rr hosts. Now they are possible because different rr hosts may have overlapping date ranges but we still want to handle individually.
emrysal
commented
Jan 22, 2025
| @@ -233,12 +237,12 @@ function buildSlotsWithDateRanges({ | |||
| }; | |||
| } | |||
|
|
|||
| slots.push(slotData); | |||
| slots.set(slotData.time.toISOString(), slotData); | |||
There was a problem hiding this comment.
Key based on start time (same as rendering in Booker)
emrysal
commented
Jan 22, 2025
| }, | ||
| // 12:00-12:20,12:20-12:40 | ||
| { | ||
| start: nextDay.hour(11).minute(20), |
There was a problem hiding this comment.
Before this resulted in 7 slots, due to 11:20/11:40 overlap with dateRanges[0]. This is now corrected to the correct (5)
… to reproduce this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?