Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to disable deleting calendar credentials for CalendarSettings atom #18759

Conversation

Ryukemeister
Copy link
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jan 20, 2025
@dosubot dosubot bot added the ✨ feature New feature or request label Jan 20, 2025
@graphite-app graphite-app bot requested a review from a team January 20, 2025 10:01
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 0:49am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 0:49am

Copy link

graphite-app bot commented Jan 20, 2025

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (01/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/22/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

E2E results are ready!

@Ryukemeister Ryukemeister enabled auto-merge (squash) January 22, 2025 12:50
@Ryukemeister Ryukemeister merged commit 586b353 into main Jan 22, 2025
38 checks passed
@Ryukemeister Ryukemeister deleted the option-to-disable-removing-calendars-for-calendar-settings-atom branch January 22, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants