-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update libphonenumber-js to fix Australian numbers validation error #18725
Conversation
@retrogtx is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/17/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/17/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@retrogtx had some questions here. Since we're going from version 1.10 to 1.11 can you make sure there are no breaking changes? Additionally can you make sure if something that we already use from the current version has not been deprecated in the next version and that there is backwards compatibility? Reason being if there's any such kind of change it would affect phone input for the whole app in the next release.
On it |
It seems like #18724 fixes the same issue |
yep, that looks fine to me as well we do need to add it in package.json too the person who raised the issue has given the solution as well actually |
there is a patch in package.json
I suppose we can get rid of this too, but need to get rid of the actual patch also Lmk if you see the latest code works fine as well |
Fixed by this:- #18757 |
What does this PR do?
Updates the libphonenumber-js to 1.11.18
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?