Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update libphonenumber-js to fix Australian numbers validation error #18725

Closed
wants to merge 2 commits into from

Conversation

retrogtx
Copy link
Contributor

@retrogtx retrogtx commented Jan 17, 2025

What does this PR do?

Updates the libphonenumber-js to 1.11.18

image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Copy link

vercel bot commented Jan 17, 2025

@retrogtx is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 17, 2025
@graphite-app graphite-app bot requested a review from a team January 17, 2025 05:59
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: Update libphonenumber-js to fix Australian numbers validation error". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels Jan 17, 2025
Copy link

graphite-app bot commented Jan 17, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/17/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx retrogtx changed the title Fix: Update libphonenumber-js to fix Australian numbers validation error fix: Update libphonenumber-js to fix Australian numbers validation error Jan 17, 2025
@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Jan 17, 2025
Copy link
Contributor

@Ryukemeister Ryukemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@retrogtx had some questions here. Since we're going from version 1.10 to 1.11 can you make sure there are no breaking changes? Additionally can you make sure if something that we already use from the current version has not been deprecated in the next version and that there is backwards compatibility? Reason being if there's any such kind of change it would affect phone input for the whole app in the next release.

@retrogtx
Copy link
Contributor Author

On it

@retrogtx retrogtx marked this pull request as draft January 17, 2025 08:30
@Ryukemeister
Copy link
Contributor

Ryukemeister commented Jan 17, 2025

It seems like #18724 fixes the same issue

@retrogtx
Copy link
Contributor Author

It seems like #18724 fixes the same issue

yep, that looks fine to me as well

we do need to add it in package.json too
along with a change in the schema

the person who raised the issue has given the solution as well actually

@retrogtx
Copy link
Contributor Author

@retrogtx had some questions here. Since we're going from version 1.10 to 1.11 can you make sure there are no breaking changes? Additionally can you make sure if something that we already use from the current version has not been deprecated in the next version and that there is backwards compatibility? Reason being if there's any such kind of change it would affect phone input for the whole app in the next release.

there is a patch in package.json

"libphonenumber-js@^1.10.51": "patch:libphonenumber-js@npm%3A1.10.51#./.yarn/patches/libphonenumber-js-npm-1.10.51-4ff79b15f8.patch",

"libphonenumber-js@^1.10.12": "patch:libphonenumber-js@npm%3A1.10.51#./.yarn/patches/libphonenumber-js-npm-1.10.51-4ff79b15f8.patch",

I suppose we can get rid of this too, but need to get rid of the actual patch also
Other than the two places, I do not think we use the libphonenumber-js package anywhere

Lmk if you see the latest code works fine as well

@anikdhabal
Copy link
Contributor

Fixed by this:- #18757

@anikdhabal anikdhabal closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libphonenumber-js version out of date. Australian numbers starting with +614943 are not validating in Calcom
3 participants