Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable cancelling past events #18643

Conversation

cnhhoang850
Copy link
Contributor

What does this PR do?

  • Disable cancelling past event records in bookings
  • TODO: Maybe create a new type of action like delete event record instead as past events should not be cancelled to avoid sending notifications to attendees

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 14, 2025

@cnhhoang850 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 14, 2025
@graphite-app graphite-app bot requested a review from a team January 14, 2025 08:00
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Jan 14, 2025
Copy link

graphite-app bot commented Jan 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/14/25)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal
Copy link
Contributor

cc @CarinaWolli do we need it?

@CarinaWolli
Copy link
Member

cc @CarinaWolli do we need it?

Don't think so, I don't find any issue or discussion to this. @cnhhoang850 is there an open issue for this? if yes, please link it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants