fix: make ESLint work and fix lint errors that were undetected before #18639

hbjORbj · 2025-01-14T05:27:32Z

What does this PR do?

fix the linter CI job that is failing: https://github.com/calcom/cal.com/actions/runs/12761448849/job/35568574169?pr=18637

Failed to load plugin '@calcom/eslint' declared in '../../.eslintrc.js#overrides[0]': Unexpected token 'export'

fixes lint errors found
syncs the version of eslint to ^8.34.0 throughout the packages

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

vercel · 2025-01-14T05:27:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jan 14, 2025 8:48am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Jan 14, 2025 8:48am

graphite-app · 2025-01-14T05:30:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (01/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2025-01-14T05:50:16Z

E2E results are ready!

Workflow #43921.1 latest results

…which ESLint requires)

hbjORbj · 2025-01-14T08:00:01Z

packages/eslint-plugin/src/index.js

-require("ts-node").register();
+require("ts-node").register({
+  compilerOptions: {
+    module: "commonjs",


force ts-node to compile our ESLint plugin's TS files into CommonJS (which ESLint requires)

hbjORbj · 2025-01-14T08:00:09Z

example-apps/credential-sync/package.json

@@ -22,7 +22,7 @@
    "@types/react-dom": "^18",
    "autoprefixer": "^10.0.1",
    "dotenv": "^16.3.1",
-    "eslint": "^8",
+    "eslint": "^8.34.0",


sync version

hbjORbj · 2025-01-14T08:00:14Z

packages/platform/examples/base/package.json

@@ -22,7 +22,7 @@
    "@types/react": "^18",
    "@types/react-dom": "^18",
    "autoprefixer": "^10.0.1",
-    "eslint": "^8",
+    "eslint": "^8.34.0",


sync version

hbjORbj · 2025-01-14T08:30:30Z

packages/config/eslint-preset.js

+        {
+          files: ["packages/trpc/**/*.{tsx,ts}"],
+          rules: {
+            "@typescript-eslint/ban-types": "warn",


otherwise, ~2500 lint errors exist in packages/trpc files

Udit-takkar · 2025-01-14T08:58:28Z

@emrysal there are still some lint failures

…#18639) * fix eslint config * fix * add it to dev dep * fix * sync eslint version * force ts-node to compile our ESLint plugin's TS files into CommonJS (which ESLint requires) * fix some lint errors * fix lint errors * remove duplicate classname * make @typescript-eslint/ban-types a warn for packages/trpc files * fix lint errors in trpc * fix lint errors in trpc - 2 * fix * fix * fix lint warnings

* Upgrade jsforce to 3.6.2 * Refactor connecting to Salesforce * Revert yarn.lock changes * Add `TASKER_ENABLE_CRM_EVENT_CREATION` to .env * Add createCRMEvent scheduler * Schedule CRM event creating in `EventManager` * Add calendar event builder for CRM tasks * Do not write to person record if fields don't exist * Change type to expect string from tasker * Create CRM event * Create booking references * Type fixes * Migrate callback endpoint * Add jsforce node dependency * Migrate add endpoint * Import * Import package into crmService * Use new package types * Type fix * Update vite config * Push updated lockfile * Attempt to bump platform/libraries to unlock jsforce * Also update lockfile, naturally * bump platform libraries * feat: salesforce to tasker improvements (#18419) * feat: salesforce to tasker * refactor: event manager * tests: add unit tests for create CRM Event * Update vite.config * Add jsforce to vite config * Revert mint.json changes * Default to not enabling * Revert yarn.lock changes * Remove `TASKER_ENABLE_CRM_EVENT_CREATION` variable * Revert yarn.lock changes * feat: Round Robin weights future members toggle (#17782) Co-authored-by: Omar López <[email protected]> * detailed customer card (#18511) Co-authored-by: Omar López <[email protected]> * chore: app router - all sub-pages in `/apps` (#16976) * chore: apps/[slug] remove pages router * remove apps/[slug] pages from /future * chore: apps/installed remove pages router * chore: apps/installation remove pages router * remove Head element * fix metadata * fix test * fix another test * chore: apps/categories remove pages router * revert unneeded changes * update middleware * Remove <Head> * remove unused import and code * remove unused import and code again * fix * fix category page * add split icon * add /routing paths to middleware matcher * wip * remove HeadSeo from App.tsx * clean up head-seo test * add generateAppMetadata * use generateAppMetadata in apps/[slug] page * delete file * remove log * fix * fix * fix apps/installed pages * fix cateogires pages * fix * fix imports * wip * fix * fix * fix metadata * fix * redirect /apps/routing-forms to /routing * replace all usages of /apps/routing-forms to /routing * better naming * /routing -> /routing/forms * fix * fix * fix * fix * remove backPath as it is irrelevant when withoutMain is true * fix type checks * fix type check in apps/[slug] * refactors * fix * fix test * fix * fix * fix * Replace multiple leading slashes with a single slash * migrate routing-forms too * add re routing * fix * add redirection --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> * chore: app router 404 page (#18597) * wip * wip * fix not found page * render middleware for /settings pages * fix * remove global-error page * add metadata to not-found page * make not-found page static * remove 404 * adding not-found to middleware is not necessary * add every routes to config.matcher * fix test * fix style * use i18n string * fix tests * fix * fix * revert unneeded changes * fix * fix * fix * fix style * fix * remove 404 * remove log * fix * fix * fix * fix * better naming * parallel testing --------- Co-authored-by: Benny Joo <[email protected]> * feat: render custom error page for unexpected sever error + remove` pages/_error` (#18606) * remove page/_error * refactor app/error * fix: app/not-found cannot be a static page (#18610) * Async False (#18611) * chore: redirect to /500 if pathname does not exist + better error handling (#18615) * fix lint error * fix booking page and better error handling * chore: gracefully handle 404s from pages router's dynamic pages + tests (#18618) * restore pages/_error * set custom header in pages/_error * handle it in middleware * add test * remove logs * better test description * chore: try using custom 404 in pages/_error (#18622) * fix: parsing teamId (#18623) * chore: restore error pages for pages router (#18625) * disable emails to all guests (#18628) Co-authored-by: CarinaWolli <[email protected]> * revert: "feat: bulk shorten links with dub.links.createMany (#18539)" (#18587) This reverts commit 4902c6a. Co-authored-by: Alex van Andel <[email protected]> * chore: release v4.8.18 * fix: disable sending sms when email is present (#18632) * fix: disable sending sms when email is present * fix: update test * fix: main lint errors (#18634) * fix: error-page.tsx related lint errors * fix: lint no continue-on-error * Adding more lint fixes * Bring back annotate code linting results * Bring back linting continue-on-error * Slimline lint * feat: do not show automation webhooks in webhook list (#18607) * fix: make ESLint work and fix lint errors that were undetected before (#18639) * fix eslint config * fix * add it to dev dep * fix * sync eslint version * force ts-node to compile our ESLint plugin's TS files into CommonJS (which ESLint requires) * fix some lint errors * fix lint errors * remove duplicate classname * make @typescript-eslint/ban-types a warn for packages/trpc files * fix lint errors in trpc * fix lint errors in trpc - 2 * fix * fix * fix lint warnings * chore: clean up config.matcher in middleware (#18638) Co-authored-by: Alex van Andel <[email protected]> * Allow lint to error but continue (unblock pipeline) * fix: potential fix for flaky layout shift (#18651) * potential fix: layout shift * fix lint error * feat: update translations via @replexica (#18598) * chore: sync with main * feat: update translations via @replexica --------- Co-authored-by: Replexica <[email protected]> * Update yarn.lock * nit: let tasker handle payload stringification --------- Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Alex van Andel <[email protected]> Co-authored-by: Morgan <[email protected]> Co-authored-by: Morgan Vernay <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Nizzy <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: Keith Williams <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Kartik Saini <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Replexica <[email protected]>

fix eslint config

d96fe1e

graphite-app bot requested a review from a team January 14, 2025 05:27

keithwillcode added consumer core area: core, team members only labels Jan 14, 2025

dosubot bot added the 🐛 bug Something isn't working label Jan 14, 2025

hbjORbj added the ready-for-e2e label Jan 14, 2025

hbjORbj changed the title ~~fix: eslint config~~ fix: @calcom/eslint is a wrong package name Jan 14, 2025

vercel bot deployed to Preview – api January 14, 2025 05:37 View deployment

hbjORbj added 2 commits January 14, 2025 00:54

fix

12c95c4

add it to dev dep

7cfe6f0

vercel bot deployed to Preview – api January 14, 2025 06:06 View deployment

fix

88586ce

vercel bot deployed to Preview – api January 14, 2025 06:21 View deployment

hbjORbj marked this pull request as draft January 14, 2025 06:23

hbjORbj changed the title ~~fix: @calcom/eslint is a wrong package name~~ fix: force ts-node to compile our ESLint plugin's TS files into CommonJS (which ESLint requires) Jan 14, 2025

hbjORbj changed the title ~~fix: force ts-node to compile our ESLint plugin's TS files into CommonJS (which ESLint requires)~~ fix: make ESLint work Jan 14, 2025

hbjORbj added 3 commits January 14, 2025 02:58

sync eslint version

17b34f8

force ts-node to compile our ESLint plugin's TS files into CommonJS (…

ed6c01e

…which ESLint requires)

fix some lint errors

5a89fb0

hbjORbj commented Jan 14, 2025

View reviewed changes

vercel bot deployed to Preview – api January 14, 2025 08:05 View deployment

fix lint errors

e1cbbec

hbjORbj changed the title ~~fix: make ESLint work~~ fix: make ESLint work and fix lint errors that were undetected before Jan 14, 2025

remove duplicate classname

70abed6

vercel bot deployed to Preview – api January 14, 2025 08:18 View deployment

hbjORbj added 2 commits January 14, 2025 03:28

make @typescript-eslint/ban-types a warn for packages/trpc files

bc8664a

fix lint errors in trpc

7b1797d

hbjORbj commented Jan 14, 2025

View reviewed changes

fix lint errors in trpc - 2

1999c95

hbjORbj marked this pull request as ready for review January 14, 2025 08:31

graphite-app bot requested a review from a team January 14, 2025 08:31

dosubot bot added ci area: CI, DX, pipeline, github actions ⬆️ dependencies Pull requests that update a dependency file labels Jan 14, 2025

Udit-takkar previously approved these changes Jan 14, 2025

View reviewed changes

fix

cf18ea9

hbjORbj dismissed Udit-takkar’s stale review via cf18ea9 January 14, 2025 08:34

vercel bot deployed to Preview – api January 14, 2025 08:42 View deployment

hbjORbj added 2 commits January 14, 2025 03:47

fix

2845140

fix lint warnings

16fe6b7

emrysal approved these changes Jan 14, 2025

View reviewed changes

emrysal merged commit 14151b8 into main Jan 14, 2025
24 of 26 checks passed

emrysal deleted the fix/eslint-config branch January 14, 2025 08:58

vercel bot deployed to Preview – api January 14, 2025 08:59 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make ESLint work and fix lint errors that were undetected before #18639

fix: make ESLint work and fix lint errors that were undetected before #18639

hbjORbj commented Jan 14, 2025 •

edited

Loading

vercel bot commented Jan 14, 2025 •

edited

Loading

graphite-app bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

hbjORbj Jan 14, 2025

hbjORbj Jan 14, 2025

hbjORbj Jan 14, 2025

hbjORbj Jan 14, 2025

Udit-takkar commented Jan 14, 2025

fix: make ESLint work and fix lint errors that were undetected before #18639

fix: make ESLint work and fix lint errors that were undetected before #18639

Conversation

hbjORbj commented Jan 14, 2025 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

vercel bot commented Jan 14, 2025 • edited Loading

graphite-app bot commented Jan 14, 2025 • edited Loading

Graphite Automations

github-actions bot commented Jan 14, 2025 • edited Loading

E2E results are ready!

hbjORbj Jan 14, 2025

Choose a reason for hiding this comment

hbjORbj Jan 14, 2025

Choose a reason for hiding this comment

hbjORbj Jan 14, 2025

Choose a reason for hiding this comment

hbjORbj Jan 14, 2025

Choose a reason for hiding this comment

Udit-takkar commented Jan 14, 2025

hbjORbj commented Jan 14, 2025 •

edited

Loading

vercel bot commented Jan 14, 2025 •

edited

Loading

graphite-app bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading