Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Routing form submitted but no booking - Salesforce actions #18616

Merged
merged 46 commits into from
Jan 14, 2025

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Jan 13, 2025

New branch of previously approved PR #18387

What does this PR do?

  • Adds an "Incomplete booking" tab to the routing form page

  • Adds config to write to a Salesforce record when the "From filled, booking not created" event is triggered

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 10:49pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 10:49pm

Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add booking incomplete actions table". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added the ❗️ migrations contains migration files label Jan 13, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 13, 2025
@joeauyeung joeauyeung changed the title Add booking incomplete actions table feat: Add booking incomplete actions table Jan 13, 2025
@joeauyeung joeauyeung changed the title feat: Add booking incomplete actions table feat: Routing form submitted but no booking - Salesforce actions Jan 13, 2025
@joeauyeung joeauyeung marked this pull request as ready for review January 14, 2025 05:16
@graphite-app graphite-app bot requested a review from a team January 14, 2025 05:16
@dosubot dosubot bot added routing-forms area: routing forms, routing, forms ✨ feature New feature or request labels Jan 14, 2025
Copy link

graphite-app bot commented Jan 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

E2E results are ready!

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge, thanks also for your walkthrough

@emrysal emrysal merged commit 66b3e73 into main Jan 14, 2025
38 checks passed
@emrysal emrysal deleted the form-submission-no-booking-options-2 branch January 14, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ✨ feature New feature or request ❗️ migrations contains migration files ready-for-e2e routing-forms area: routing forms, routing, forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants