Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Dub version to fix createMany error #18591

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

steven-tey
Copy link
Contributor

What does this PR do?

Upgrade dub version to fix createMany error (@see: dubinc/dub#1876)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Test both cases where all 3 links are valid vs 2 valid links + 1 invalid link to make sure it works as expected

Copy link

vercel bot commented Jan 10, 2025

@steven-tey is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team January 10, 2025 16:53
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 10, 2025
@graphite-app graphite-app bot requested a review from a team January 10, 2025 16:53
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Bump Dub version to fix createMany error". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Jan 10, 2025
Copy link

graphite-app bot commented Jan 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (01/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/10/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/10/25)

1 label was added to this PR based on Keith Williams's automation.

PeerRich
PeerRich previously approved these changes Jan 10, 2025
@PeerRich PeerRich enabled auto-merge (squash) January 10, 2025 16:56
Copy link

socket-security bot commented Jan 10, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@keithwillcode keithwillcode changed the title Bump Dub version to fix createMany error chore: Bump Dub version to fix createMany error Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

E2E results are ready!

@zomars
Copy link
Member

zomars commented Jan 10, 2025

Seems like API V2 is breaking https://github.com/calcom/cal.com/actions/runs/12713782361/job/35444795473?pr=18591

Can you verify? @supalarry

auto-merge was automatically disabled January 10, 2025 20:55

Head branch was pushed to by a user without write access

Copy link

socket-security bot commented Jan 13, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@gar/[email protected] None 0 4.2 kB gar
npm/@humanwhocodes/[email protected] unsafe 0 21.2 kB nzakas
npm/@istanbuljs/[email protected] None 0 17.2 kB coreyfarrell
npm/@nodelib/[email protected] filesystem 0 22.2 kB mrmlnc
npm/@nodelib/[email protected] filesystem 0 11.8 kB mrmlnc
npm/@nodelib/[email protected] None 0 26.4 kB mrmlnc
npm/@npmcli/[email protected] filesystem 0 38.9 kB gar
npm/@npmcli/[email protected] filesystem 0 8.73 kB gar
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/@tootallnate/[email protected] None 0 16.3 kB tootallnate
npm/[email protected] None 0 4.78 kB isaacs
npm/[email protected] None 0 24.4 kB rreverser
npm/[email protected] None 0 6.69 kB sindresorhus
npm/[email protected] None 0 52.2 kB esp
npm/[email protected] None 0 5.61 kB qix
npm/[email protected] None 0 8.05 kB iarna
npm/[email protected] None 0 14.3 kB lukekarrys
npm/[email protected] None 0 3.17 kB sindresorhus
npm/[email protected] None 0 3.4 kB kevva
npm/[email protected] None 0 27.4 kB alexindigo
npm/[email protected] None 0 2.63 kB ryanzim
npm/[email protected] filesystem 0 93.3 kB fabiospampinato
npm/[email protected] None 0 6.94 kB juliangruber
npm/[email protected] 🔁 npm/[email protected] None 0 9.62 kB feross
npm/[email protected] None 0 64.4 kB matteo.collina
npm/[email protected] None 0 5.05 kB linusu
npm/[email protected] None 0 82.5 kB feross
npm/[email protected] None 0 6.33 kB sindresorhus
npm/[email protected] filesystem 0 74.8 kB runk
npm/[email protected] filesystem 0 5.75 kB isaacs
npm/[email protected] None 0 5.51 kB sindresorhus
npm/[email protected] None 0 4.37 kB sindresorhus
npm/[email protected] None 0 11.1 kB pvorb
npm/[email protected] None 0 9.23 kB isaacs
npm/[email protected] None 0 11.5 kB alexindigo
npm/[email protected] None 0 4.86 kB substack
npm/[email protected] None 0 12.7 kB iarna
npm/[email protected] None 0 15.9 kB phated
npm/[email protected] None 0 8.11 kB thlorenz
npm/[email protected] None 0 8.02 kB apechimp
npm/[email protected] None 0 7.46 kB tjholowaychuk
npm/[email protected] None 0 5.42 kB sindresorhus
npm/[email protected] None 0 10.2 kB sindresorhus
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 48.3 kB mathias
npm/[email protected] None 0 10.2 kB sindresorhus
npm/[email protected] None 0 12.3 kB achingbrain
npm/[email protected] None 0 9.04 kB qix
npm/[email protected] None 0 40.4 kB ljharb
npm/[email protected] None 0 3.79 kB sindresorhus
npm/[email protected] None 0 314 kB ariya
npm/[email protected] None 0 13.5 kB michaelficarra
npm/[email protected] None 0 50.6 kB michaelficarra
npm/[email protected] None 0 37.3 kB sssayegh
npm/[email protected] None 0 17 kB esp
npm/[email protected] None 0 9.44 kB hiddentao
npm/[email protected] filesystem +1 57.5 kB mde
npm/[email protected] None 0 11.8 kB sindresorhus
npm/[email protected] environment, filesystem 0 13.4 kB isaacs
npm/[email protected] None 0 16.7 kB ljharb
npm/[email protected] None 0 8.68 kB keithamus
npm/[email protected] None 0 12.2 kB sindresorhus
npm/[email protected] filesystem 0 21.8 kB sindresorhus
npm/[email protected] None 0 12.8 kB ljharb
npm/[email protected] None 0 4.42 kB sindresorhus
npm/[email protected] environment 0 3.44 kB iarna
npm/[email protected] None 0 35.9 kB kornel
npm/[email protected] network 0 17.1 kB tootallnate
npm/[email protected] None 0 44.3 kB ehmicky
npm/[email protected] None 0 3.66 kB dead_horse
npm/[email protected] None 0 6.8 kB feross
npm/[email protected] None 0 11.9 kB jensyt
npm/[email protected] None 0 4.4 kB sindresorhus
npm/[email protected] filesystem 0 4.29 kB isaacs
npm/[email protected] None 0 3.76 kB isaacs
npm/[email protected] None 0 3.96 kB isaacs
npm/[email protected] 🔁 npm/[email protected] None 0 4.05 kB qix
npm/[email protected] 🔁 npm/[email protected] None 0 14.8 kB ljharb
npm/[email protected] None 0 22.1 kB ljharb
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None 0 20.8 kB ljharb
npm/[email protected] None 0 6.22 kB jonschlinkert
npm/[email protected] None 0 4.99 kB sindresorhus
npm/[email protected] None 0 4.62 kB sindresorhus
npm/[email protected] None 0 2.94 kB watson
npm/[email protected] None 0 22.2 kB ljharb
npm/[email protected] None 0 9.62 kB jonschlinkert
npm/[email protected] None 0 2.82 kB sindresorhus
npm/[email protected] None 0 4.12 kB sindresorhus
npm/[email protected] None 0 30.1 kB ljharb
npm/[email protected] None 0 5.93 kB sindresorhus
npm/[email protected] None 0 19.1 kB ljharb
npm/[email protected] None 0 22 kB ljharb
npm/[email protected] None 0 3.54 kB sindresorhus
npm/[email protected] None 0 12.1 kB ljharb
npm/[email protected] environment, filesystem 0 11 kB isaacs
npm/[email protected] None 0 15.1 kB lydell
npm/[email protected] None 0 405 kB vitaly
npm/[email protected] None 0 46.9 kB andyperlitch
npm/[email protected] None 0 10.4 kB isaacs
npm/[email protected] None 0 56.9 kB jayrylan
npm/[email protected] None 0 14.2 kB samn
npm/[email protected] filesystem 0 16.9 kB ryanzim
npm/[email protected] None 0 22.8 kB doowb
npm/[email protected] None 0 8.32 MB catamphetamine
npm/[email protected] None 0 5.39 kB eventualbuddha
npm/[email protected] filesystem 0 7.02 kB sindresorhus
npm/[email protected] None 0 54.1 kB jdalton
npm/[email protected] None 0 1.41 MB bnjmnt4n
npm/[email protected] None 0 4.58 kB sindresorhus
npm/[email protected] filesystem 0 10 kB sindresorhus
npm/[email protected] None 0 4.31 kB stevemao
npm/[email protected] None 0 206 kB dougwilson
npm/[email protected] None 0 18.3 kB dougwilson
npm/[email protected] None 0 2.97 kB thejameskyle
npm/[email protected] None 0 7 kB isaacs
npm/[email protected] None 0 124 kB isaacs
npm/[email protected] None 0 48.1 kB isaacs
npm/[email protected] None 0 5.65 kB megawac
npm/[email protected] None 0 9.22 kB jonschlinkert
npm/[email protected] environment 0 8.13 kB sindresorhus
npm/[email protected] None 0 17.1 kB lukekarrys
npm/[email protected] None 0 26.5 kB ljharb
npm/[email protected] None 0 4.05 kB isaacs
npm/[email protected] None 0 3.06 kB sindresorhus
npm/[email protected] None 0 7.75 kB sindresorhus
npm/[email protected] None 0 7.24 kB sindresorhus
npm/[email protected] None 0 4.37 kB sindresorhus
npm/[email protected] None 0 3.92 kB sindresorhus
npm/[email protected] None 0 5.41 kB sindresorhus
npm/[email protected] None 0 3.62 kB sindresorhus
npm/[email protected] None 0 4.51 kB jbgutierrez
npm/[email protected] filesystem 0 5.41 kB sindresorhus
npm/[email protected] None 0 4.25 kB sindresorhus
npm/[email protected] None 0 36.7 kB gkz
npm/[email protected] None 0 12.3 kB npm-cli-ops
npm/[email protected] None 0 3.17 kB cwmma
npm/[email protected] None 0 3.04 kB iarna
npm/[email protected] None 0 15.6 kB achingbrain
npm/[email protected] None 0 8.37 kB feross
npm/[email protected] filesystem 0 6.05 kB sindresorhus
npm/[email protected] filesystem 0 12.1 kB troygoode
npm/[email protected] unsafe 0 3.42 kB floatdrop
npm/[email protected] filesystem, unsafe 0 4.64 kB sindresorhus
npm/[email protected] None 0 32.2 kB tim-kos
npm/[email protected] None 0 9.44 kB matteo.collina
npm/[email protected] None 0 6.6 kB sboudrias
npm/[email protected] None 0 6.56 kB feross
npm/[email protected] None 0 42.3 kB chalker
npm/[email protected] None 0 4.22 kB bcoe
npm/[email protected] None 0 2.56 kB kevva
npm/[email protected] None 0 2.83 kB sindresorhus
npm/[email protected] None 0 6.79 kB terkelg
npm/[email protected] None 0 3.51 kB sindresorhus
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] None 0 11.8 kB kemitchell
npm/[email protected] unsafe +1 17.9 kB isaacs
npm/[email protected] None 0 14.4 kB matteo.collina
npm/[email protected] None 0 0 B
npm/[email protected] None 0 0 B
npm/[email protected] None 0 3 kB sindresorhus
npm/[email protected] None 0 3.05 kB sindresorhus
npm/[email protected] None 0 3.31 kB sindresorhus
npm/[email protected] None +1 14 kB sindresorhus
npm/[email protected] None 0 9.18 kB ljharb
npm/[email protected] None 0 12.5 kB dominictarr
npm/[email protected] None 0 22.9 kB jonschlinkert
npm/[email protected] 🔁 npm/[email protected] None 0 111 kB sindresorhus
npm/[email protected] None 0 14.9 kB ljharb
npm/[email protected] None 0 2.62 kB lukekarrys
npm/[email protected] None 0 4.71 kB ryanzim
npm/[email protected] None 0 470 kB garycourt
npm/[email protected] None 0 5.48 kB tootallnate
npm/[email protected] None 0 16.6 kB kemitchell
npm/[email protected] None 0 14.2 kB timoxley
npm/[email protected] None 0 15 kB ljharb
npm/[email protected] None 0 4.47 kB iarna
npm/[email protected] None 0 3.73 kB sindresorhus
npm/[email protected] None 0 0 B
npm/[email protected] None 0 2.96 kB zkat
npm/[email protected] None 0 6.46 kB raynos
npm/[email protected] filesystem 0 23.4 kB oss-bot

🚮 Removed packages: npm/@formkit/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@emrysal
Copy link
Contributor

emrysal commented Jan 13, 2025

Hi @steven-tey Dub seems to have a commonJS issue, putting this back into draft. Fixed some type issues and will revert createMany from main.

@emrysal emrysal marked this pull request as draft January 13, 2025 18:02
@steven-tey
Copy link
Contributor Author

steven-tey commented Jan 16, 2025

Edit: We just pushed a new version of dub that should fix the commonJS issues!

@emrysal thanks for reviewing! however, I couldn't repro this error on https://github.com/dubinc/dublet

Should we maybe create a separate package / service for dub? We're currently importing from the auth package which feels a bit odd architecture-wise (and I think could be the cause of the error here).

@steven-tey steven-tey marked this pull request as ready for review January 16, 2025 20:23
zomars
zomars previously approved these changes Jan 16, 2025
@zomars zomars merged commit 6be69b8 into calcom:main Jan 17, 2025
34 of 38 checks passed
@emrysal
Copy link
Contributor

emrysal commented Jan 17, 2025

Nice work @steven-tey - sorry I was occupied with a release issue yesterday. Based on the edit the issue was discovered in dub and rectified? Nice work 💯!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants