-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Dub version to fix createMany error #18591
Conversation
@steven-tey is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/10/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (01/10/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/10/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/10/25)1 label was added to this PR based on Keith Williams's automation. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
E2E results are ready! |
Seems like API V2 is breaking https://github.com/calcom/cal.com/actions/runs/12713782361/job/35444795473?pr=18591 Can you verify? @supalarry |
Head branch was pushed to by a user without write access
Hi @steven-tey Dub seems to have a commonJS issue, putting this back into draft. Fixed some type issues and will revert createMany from main. |
Edit: We just pushed a new version of @emrysal thanks for reviewing! however, I couldn't repro this error on https://github.com/dubinc/dublet Should we maybe create a separate package / service for |
Nice work @steven-tey - sorry I was occupied with a release issue yesterday. Based on the edit the issue was discovered in dub and rectified? Nice work 💯! |
What does this PR do?
Upgrade
dub
version to fixcreateMany
error (@see: dubinc/dub#1876)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Test both cases where all 3 links are valid vs 2 valid links + 1 invalid link to make sure it works as expected