-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve routing insights view (2) #18566
Merged
keithwillcode
merged 1 commit into
main
from
eunjae/cal-4995-insights-routing-performance-issue
Jan 14, 2025
Merged
perf: improve routing insights view (2) #18566
keithwillcode
merged 1 commit into
main
from
eunjae/cal-4995-insights-routing-performance-issue
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
changed the title
Eunjae/cal 4995 insights routing performance issue
perf: improve routing insights view (2)
Jan 9, 2025
eunjae-lee
force-pushed
the
eunjae/cal-4995-insights-routing-performance-issue
branch
from
January 9, 2025 16:59
89869ea
to
7979899
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
the
performance
area: performance, page load, slow, slow endpoints, loading screen, unresponsive
label
Jan 9, 2025
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/09/25)1 reviewer was added to this PR based on Keith Williams's automation. |
Ran migration locally and opened report. Everything ran fine. |
Also tested underlying query against prod. Good perf. |
E2E results are ready! |
keithwillcode
approved these changes
Jan 14, 2025
keithwillcode
deleted the
eunjae/cal-4995-insights-routing-performance-issue
branch
January 14, 2025 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consumer
core
area: core, team members only
❗️ migrations
contains migration files
performance
area: performance, page load, slow, slow endpoints, loading screen, unresponsive
ready-for-e2e
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up of #18557. It removes
assignment_reasons_agg
and moves it into a subquery.diff of the two migrations:
Mandatory Tasks (DO NOT REMOVE)