Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show ooo forwarding and emoji when not available #18054

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Dec 7, 2024

What does this PR do?

show.ooo.when.unavailable.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Create a busy event on your calendar for a specific date.
  • Mark yourself as "Out of Office" (OOO) for the same date as the busy event.
  • Navigate to the booking page for an event.
  • Verify that the date is now marked as OOO, even though it is unavailable due to the busy event on the calendar.

Copy link

vercel bot commented Dec 7, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 7, 2024
@graphite-app graphite-app bot requested a review from a team December 7, 2024 16:40
Copy link

graphite-app bot commented Dec 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/07/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar Medium priority Created by Linear-GitHub Sync labels Dec 7, 2024
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ✨ feature New feature or request labels Dec 7, 2024
packages/lib/slots.ts Outdated Show resolved Hide resolved
packages/lib/slots.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 9, 2024

E2E results are ready!

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kart1ka e2e tests are failing, please fix it 🙏

@kart1ka
Copy link
Contributor Author

kart1ka commented Dec 10, 2024

@kart1ka e2e tests are failing, please fix it 🙏

@Praashh Those tests are failing on the main branch as well.

@dosubot dosubot bot added this to the v4.9 milestone Dec 15, 2024
@Praashh
Copy link
Contributor

Praashh commented Jan 4, 2025

LGTM!! but blocking it because of failure of test cases

@kart1ka kart1ka marked this pull request as draft January 6, 2025 09:05
@anikdhabal anikdhabal marked this pull request as ready for review January 8, 2025 03:11
@kart1ka
Copy link
Contributor Author

kart1ka commented Jan 15, 2025

Hey @Praashh I have fixed the failing test. Please re-review.

@kart1ka kart1ka requested a review from Praashh January 15, 2025 07:28
@dosubot dosubot bot modified the milestones: v4.9, v4.10 Jan 16, 2025
@PeerRich PeerRich requested a review from CarinaWolli January 17, 2025 08:38
@PeerRich
Copy link
Member

i dont yet understand yet waht this PR fixes. the video looks the same like the current behaviour @Praashh

@kart1ka
Copy link
Contributor Author

kart1ka commented Jan 21, 2025

i dont yet understand yet waht this PR fixes. the video looks the same like the current behaviour @Praashh

Hi @PeerRich This PR adds the feature to always show ooo emoji and the button to redirect to team member (member1 in the video) even when the user (owner1 in the video) is not available at that time (10 dec in the video).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4704] Show OOO emoji and forwarding when not available
5 participants