-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show ooo forwarding and emoji when not available #18054
base: main
Are you sure you want to change the base?
feat: show ooo forwarding and emoji when not available #18054
Conversation
@kart1ka is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/07/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/07/24)1 label was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kart1ka e2e tests are failing, please fix it 🙏
LGTM!! but blocking it because of failure of test cases |
Hey @Praashh I have fixed the failing test. Please re-review. |
i dont yet understand yet waht this PR fixes. the video looks the same like the current behaviour @Praashh |
Hi @PeerRich This PR adds the feature to always show ooo emoji and the button to redirect to team member (member1 in the video) even when the user (owner1 in the video) is not available at that time (10 dec in the video). |
What does this PR do?
show.ooo.when.unavailable.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?