Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated city-timezones to support Kyiv #17159

Closed
wants to merge 66 commits into from

Conversation

AlexHladin
Copy link

What does this PR do?

This PR fixes the incorrect timezone name for Kyiv.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Oct 18, 2024

@AlexHladin is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 18, 2024
@graphite-app graphite-app bot requested review from a team October 18, 2024 10:41
@github-actions github-actions bot added the 🐛 bug Something isn't working label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Updated city-timezones to support Kyiv". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Oct 18, 2024
@dosubot dosubot bot added this to the v4.7 milestone Oct 18, 2024
@AlexHladin AlexHladin changed the title Updated city-timezones to support Kyiv fix: Updated city-timezones to support Kyiv Oct 18, 2024
Copy link

graphite-app bot commented Oct 18, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/18/24)

1 label was added to this PR based on Keith Williams's automation.

zomars
zomars previously approved these changes Oct 24, 2024
@zomars zomars enabled auto-merge (squash) October 24, 2024 16:09
Copy link
Contributor

github-actions bot commented Oct 24, 2024

E2E results are ready!

PeerRich
PeerRich previously approved these changes Oct 30, 2024
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing

auto-merge was automatically disabled November 14, 2024 09:00

Head branch was pushed to by a user without write access

@dosubot dosubot bot modified the milestone: v4.9 Dec 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.8, v4.9 Dec 15, 2024
@AlexHladin AlexHladin force-pushed the fix-timezone-name-for-kyiv branch from 541473e to 12ec88f Compare January 6, 2025 17:39
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@formkit/[email protected] None 0 35.4 kB justin-schroeder
npm/@types/[email protected] None 0 3.37 kB types
npm/@types/[email protected] None 0 868 kB types
npm/@types/[email protected] None 0 3.38 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected], npm/@types/[email protected] None 0 1.63 MB types
npm/[email protected] None 0 23.6 kB jedwatson
npm/[email protected] None 0 669 kB kewisch

🚮 Removed packages: npm/@axiomhq/[email protected], npm/@calcom/[email protected], npm/@calcom/[email protected], npm/@golevelup/[email protected], npm/@microsoft/[email protected], npm/@nest-lab/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@zomars
Copy link
Member

zomars commented Jan 14, 2025

Closing this PR as it is doing way more that describes. Feel free to re-open with only the relevant parts. Also feel free to open another one with type improvements if necessary.

@zomars zomars closed this Jan 14, 2025
@hbjORbj
Copy link
Contributor

hbjORbj commented Jan 14, 2025

@AlexHladin Hey Alex, there's lots of type improvements going on in this PR. While we massively appreciate it, it makes it very difficult to review. Please open a fresh PR and request me a review.

@dosubot dosubot bot modified the milestone: v4.9 Jan 14, 2025
@AlexHladin
Copy link
Author

@hbjORbj @zomars types changes are required, because react-timezone requires it. I can't skip types improvement things.

@dosubot dosubot bot modified the milestones: v4.9, v4.10 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4073] Kyiv timezone missing
5 participants