-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reducing E2E test sharding #15192
Merged
+20
−23
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3dc13d9
chore: Removing E2E test sharding
keithwillcode 26c651c
Added back 4 shards for main E2E
keithwillcode 19ca878
Bump build machines to use 8vCPUs
keithwillcode 1e4a68b
Downgrading builds to 2 vCPUs to see time difference
keithwillcode 19b3a9a
Reduced shards to 2 to see if flakes are reduced
keithwillcode ff29ee6
Increased E2E vCPUs
keithwillcode cb2375c
Put builds back to 4 vCPUs since they need it
keithwillcode 736eb94
Updated E2E suite to use 16 vCPUs and no sharding
keithwillcode aa6547c
Not running in parallel just to test
keithwillcode ff1e888
Put back the parallelism
keithwillcode 9c994b7
Get rid of themeBasis warning in test suite
keithwillcode e0d097f
Skipping another flaky test
keithwillcode c9eabdb
2 shards
keithwillcode 1e600be
Update e2e.yml
keithwillcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -215,7 +215,7 @@ function getThemeProviderProps({ | |
const isBookingPageThemeSupportRequired = themeSupport === ThemeSupport.Booking; | ||
const themeBasis = props.themeBasis; | ||
|
||
if ((isBookingPageThemeSupportRequired || isEmbedMode) && !themeBasis) { | ||
if (!process.env.NEXT_PUBLIC_IS_E2E && (isBookingPageThemeSupportRequired || isEmbedMode) && !themeBasis) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This gets rid of hundreds of instances of this message when the E2E suite runs. |
||
console.warn( | ||
"`themeBasis` is required for booking page theme support. Not providing it will cause theme flicker." | ||
); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets rid of hundreds of instances of this message when the E2E suite runs.