better naming

calcom · Jan 21, 2025 · 9290e43 · 9290e43
1 parent 203b38c
commit 9290e43
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 19 deletions.
diff --git a/packages/features/bookings/Booker/Booker.tsx b/packages/features/bookings/Booker/Booker.tsx
@@ -152,14 +152,14 @@ const BookerComponent = ({
     }
   };
 
-  const skipEventBooker = useSkipConfirmStep(bookingForm, event?.data?.bookingFields);
+  const skipConfirmStep = useSkipConfirmStep(bookingForm, event?.data?.bookingFields);
 
   useEffect(() => {
     if (event.isPending) return setBookerState("loading");
     if (!selectedDate) return setBookerState("selecting_date");
-    if (!selectedTimeslot || skipEventBooker) return setBookerState("selecting_time");
+    if (!selectedTimeslot || skipConfirmStep) return setBookerState("selecting_time");
     return setBookerState("booking");
-  }, [event, selectedDate, selectedTimeslot, setBookerState, skipEventBooker]);
+  }, [event, selectedDate, selectedTimeslot, setBookerState, skipConfirmStep]);
 
   const slot = getQueryParam("slot");
   useEffect(() => {
@@ -254,7 +254,6 @@ const BookerComponent = ({
     verifyCode?.verifyCodeWithSessionNotRequired,
     verifyCode?.verifyCodeWithSessionRequired,
     isPlatform,
-    onSubmit,
   ]);
 
   /**
@@ -451,7 +450,7 @@ const BookerComponent = ({
                 renderConfirmNotVerifyEmailButtonCond={renderConfirmNotVerifyEmailButtonCond}
                 isVerificationCodeSending={isVerificationCodeSending}
                 onSubmit={onSubmit}
-                skipEventBooker={skipEventBooker}
+                skipConfirmStep={skipConfirmStep}
               />
             </BookerSection>
           </AnimatePresence>

diff --git a/packages/features/bookings/Booker/components/AvailableTimeSlots.tsx b/packages/features/bookings/Booker/components/AvailableTimeSlots.tsx
@@ -34,7 +34,7 @@ type AvailableTimeSlotsProps = {
   isVerificationCodeSending: boolean;
   renderConfirmNotVerifyEmailButtonCond: boolean;
   onSubmit: (timeSlot?: string) => void;
-  skipEventBooker: boolean;
+  skipConfirmStep: boolean;
 };
 
 /**
@@ -48,13 +48,11 @@ type AvailableTimeSlotsProps = {
 export const AvailableTimeSlots = ({
   extraDays,
   limitHeight,
-  seatsPerTimeSlot,
   showAvailableSeatsCount,
   schedule,
   isLoading,
-  event,
   customClassNames,
-  skipEventBooker,
+  skipConfirmStep,
   onSubmit,
   ...props
 }: AvailableTimeSlotsProps) => {
@@ -81,7 +79,7 @@ export const AvailableTimeSlots = ({
         showAvailableSeatsCount,
       });
     }
-    if (skipEventBooker) {
+    if (skipConfirmStep) {
       onSubmit(time);
     }
     return;
@@ -148,10 +146,8 @@ export const AvailableTimeSlots = ({
                 showTimeFormatToggle={!isColumnView}
                 onTimeSelect={onTimeSelect}
                 slots={slots.slots}
-                seatsPerTimeSlot={seatsPerTimeSlot}
                 showAvailableSeatsCount={showAvailableSeatsCount}
-                event={event}
-                skipEventBooker={skipEventBooker}
+                skipConfirmStep={skipConfirmStep}
                 {...props}
               />
             </div>

diff --git a/packages/features/bookings/Booker/components/hooks/useSkipConfirmStep.ts b/packages/features/bookings/Booker/components/hooks/useSkipConfirmStep.ts
@@ -35,7 +35,7 @@ const useSkipConfirmStep = (
     };
 
     checkSkipStep();
-  }, [bookingFormValues, bookingFields]);
+  }, [bookingFormValues, bookingFields, rescheduleUid]);
 
   return canSkip;
 };

diff --git a/packages/features/bookings/components/AvailableTimes.tsx b/packages/features/bookings/components/AvailableTimes.tsx
@@ -49,7 +49,7 @@ type SlotItemProps = {
   loadingStates: IUseBookingLoadingStates;
   isVerificationCodeSending: boolean;
   renderConfirmNotVerifyEmailButtonCond: boolean;
-  skipEventBooker: boolean;
+  skipConfirmStep: boolean;
 };
 
 const SlotItem = ({
@@ -63,7 +63,7 @@ const SlotItem = ({
   loadingStates,
   renderConfirmNotVerifyEmailButtonCond,
   isVerificationCodeSending,
-  skipEventBooker,
+  skipConfirmStep,
 }: SlotItemProps) => {
   const { t } = useLocale();
 
@@ -102,7 +102,7 @@ const SlotItem = ({
   const [showConfirm, setShowConfirm] = useState(false);
 
   const onButtonClick = useCallback(() => {
-    if (!showConfirm && (isOverlapping || skipEventBooker)) {
+    if (!showConfirm && (isOverlapping || skipConfirmStep)) {
       setShowConfirm(true);
       return;
     }
@@ -117,7 +117,7 @@ const SlotItem = ({
     slot?.attendees,
     slot.bookingUid,
     seatsPerTimeSlot,
-    skipEventBooker,
+    skipConfirmStep,
   ]);
 
   return (
@@ -166,7 +166,7 @@ const SlotItem = ({
           <HoverCard.Root>
             <HoverCard.Trigger asChild>
               <m.div initial={{ width: 0 }} animate={{ width: "auto" }} exit={{ width: 0 }}>
-                {skipEventBooker ? (
+                {skipConfirmStep ? (
                   <Button
                     type="button"
                     onClick={() =>