-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ods to tods #78
Conversation
@jfabi and @safrazier17 my apologies, I did this before seeing that there is #71 already open for it. I modified more files here, including index.md which generates the landing page of the site, maybe we can use this one instead? |
@isabelle-dr this is great; happy to use this one and close #71 |
Okay, could you give me the review here? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Isabelle, made some requested additions, and added a few of the copy edits that i had on my previous PR into yours.
@isabelle-dr, would you be able to take another look at this branch when you next have a chance? Thanks! |
@safrazier17 and @jfabi, thank you for the review! I made the fixes requested and updated |
Co-authored-by: Joshua Fabian <[email protected]>
Co-authored-by: Joshua Fabian <[email protected]>
@jfabi and @safrazier17 I made the changes requested, please take another look. |
Looks good to me @isabelle-dr, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small clarification to make, but otherwise this is looking very good, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @isabelle-dr!
@jfabi @safrazier17 it seems like I need a review from a maintainer, who would it be? |
@thekaveman I assume that you are one as a repo owner, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfabi @safrazier17 it seems like I need a review from a maintainer, who would it be? Also, do you know what is failing in the
pre-commit.ci
tests?@thekaveman I assume that you are one as a repo owner, can you take a look?
The pre-commit checks are failing for a number of Markdown formatting issues. Nothing looks to be critical, so I leave it to you all if you want to address these or just go with it as-is. I will note that if these aren't fixed at some point, the warnings will continue.
Output:
docs/governance/governance.md:37:3 MD051/link-fragments Link fragments should be valid [Context: "[TODS Specification](#operational-data-standard-tods-specification)"]
docs/governance/governance.md:70:20 MD051/link-fragments Link fragments should be valid [Context: "[TODS Specification](#operational-data-standard-tods-specification)"]
docs/governance/governance.md:74:66 MD051/link-fragments Link fragments should be valid [Context: "[TODS Specification](#operational-data-standard-TODS-specification)"]
docs/governance/governance.md:78:47 MD051/link-fragments Link fragments should be valid [Context: "[TODS Specification](#operational-data-standard-tods-specification)"]
docs/governance/governance.md:95:5 MD051/link-fragments Link fragments should be valid [Context: "[TODS Specification](#operational-data-standard-tods-specification)"]
docs/governance/governance.md:112:60 MD051/link-fragments Link fragments should be valid [Expected: #tods-board-of-directors; Actual: #TODS-board-of-directors] [Context: "[TODS Board of Directors](#TODS-board-of-directors)"]
docs/governance/governance.md:118:143 MD051/link-fragments Link fragments should be valid [Context: "[TODS Specification](#operational-data-standard-tods-specification)"]
docs/governance/governance.md:119:98 MD051/link-fragments Link fragments should be valid [Expected: #tods-manager; Actual: #TODS-manager] [Context: "[TODS Manager](#TODS-manager)"]
docs/governance/governance.md:121:96 MD051/link-fragments Link fragments should be valid [Expected: #tods-board-of-directors; Actual: #TODS-board-of-directors] [Context: "[TODS Board](#TODS-board-of-directors)"]
docs/governance/policies/change-management-versioning.md:202:1 MD053/link-image-reference-definitions Link and image reference definitions should be needed [Unused link or image reference definition: "tods-spec"] [Context: "[tods-spec]: ../governance.md#..."]
docs/index.md:73 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
docs/index.md:78 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
docs/spec/examples.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "f# Examples"]
docs/spec/revision-history.md:6 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* Removes files `deadheads.txt..."]
docs/spec/revision-history.md:8:1 MD007/ul-indent Unordered list indentation [Expected: 4; Actual: 3]
Thanks @thekaveman. I will merge for now and make a note to fix the MD when I get back from leave |
ODS was renamed to TODS in June 2024.
This PR renames ODS to TODS so it appears everywhere on the website and there is no confusion.