Scale back the sending rate automatically when timeouts are encountered. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since #27 fixed the issue we encountered, I think we should hold this branch as work in progress for now, until we encounter it in the field again OR if part/all of this still looks valuable to merge now, @copelco @simonkagwi . |
|
@tobiasmcnulty That sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR scales back the sending rate (
mt_messages_per_secondattribute) of the SMPP client when a timeout is encountered. By default the sending rate is reduced by a quarter, but this can be changed in a subclass by overriding theget_new_mt_messages_per_secondmethod.Also, any exceptions encountered during sending of messages are caught and logged, the status of the message is updated to "error", and a string representation of the exception is saved in a new
errorfield.