Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send high priority, transactional messages before bulk messages #25

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

simonkagwi
Copy link
Contributor

@simonkagwi simonkagwi commented Nov 11, 2024

This adds a priority_flag field in the MTMessage model, which is then used to order the messages when fetching them from the DB, so that high priority messages are sent first. If a client is created with --set-priority-flag in the command line, it will include the saved priority_flag in the PDU when sending the messages.

@simonkagwi simonkagwi force-pushed the transactional-mt-messages-only branch from ecdf396 to f5ea146 Compare November 11, 2024 18:46
@simonkagwi simonkagwi force-pushed the transactional-mt-messages-only branch from f5ea146 to 26f773e Compare November 11, 2024 18:51
@simonkagwi simonkagwi changed the title Allow running a SMPP client that only listens for transactional MT messages. Update SMPP client to send high priority, transactional messages before bulk messages Nov 13, 2024
Copy link
Member

@tobiasmcnulty tobiasmcnulty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few minor nitpicks and one question.

src/smpp_gateway/router.py Outdated Show resolved Hide resolved
src/smpp_gateway/router.py Show resolved Hide resolved
src/smpp_gateway/router.py Outdated Show resolved Hide resolved
@simonkagwi simonkagwi marked this pull request as ready for review November 14, 2024 10:26
Copy link
Member

@tobiasmcnulty tobiasmcnulty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor nitpicks, then :shipit:

src/smpp_gateway/router.py Outdated Show resolved Hide resolved
src/smpp_gateway/router.py Show resolved Hide resolved
@tobiasmcnulty tobiasmcnulty changed the title Update SMPP client to send high priority, transactional messages before bulk messages Send high priority, transactional messages before bulk messages Nov 14, 2024
@simonkagwi simonkagwi merged commit 40116cc into main Nov 14, 2024
5 checks passed
@simonkagwi simonkagwi deleted the transactional-mt-messages-only branch November 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SMPP client to send high priority, transactional messages before bulk messages
2 participants