-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send high priority, transactional messages before bulk messages #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonkagwi
force-pushed
the
transactional-mt-messages-only
branch
from
November 11, 2024 18:46
ecdf396
to
f5ea146
Compare
simonkagwi
force-pushed
the
transactional-mt-messages-only
branch
from
November 11, 2024 18:51
f5ea146
to
26f773e
Compare
6 tasks
simonkagwi
changed the title
Allow running a SMPP client that only listens for transactional MT messages.
Update SMPP client to send high priority, transactional messages before bulk messages
Nov 13, 2024
tobiasmcnulty
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A few minor nitpicks and one question.
…nd PriorityOutgoingMessage.
…Message, and PriorityBlockingRouter.
tobiasmcnulty
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor nitpicks, then
Co-authored-by: Tobias McNulty <[email protected]>
Co-authored-by: Colin Copeland <[email protected]> Co-authored-by: Simon Kagwi <[email protected]>
tobiasmcnulty
changed the title
Update SMPP client to send high priority, transactional messages before bulk messages
Send high priority, transactional messages before bulk messages
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
priority_flag
field in the MTMessage model, which is then used to order the messages when fetching them from the DB, so that high priority messages are sent first. If a client is created with--set-priority-flag
in the command line, it will include the savedpriority_flag
in the PDU when sending the messages.