Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for log file mode directive #436

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Add docs for log file mode directive #436

merged 1 commit into from
Jan 2, 2025

Conversation

jjlin
Copy link
Contributor

@jjlin jjlin commented Jan 2, 2025

mholt
mholt approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mholt mholt merged commit f378fbf into caddyserver:master Jan 2, 2025
@jjlin jjlin deleted the log-mode branch January 2, 2025 20:06
@ririsoft
Copy link

ririsoft commented Jan 4, 2025

@mholt : I already had a pending pull request for the documentation that your approved but did not merged #399.
Maybe it would be worth to merge the 2 together ?

@mholt
Copy link
Member

mholt commented Jan 7, 2025

@ririsoft Yes, sorry; would be happy to do it. Do you have a moment to resolve the conflict on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjlin @ririsoft @mholt