Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group environment files into a folder #982

Closed
wants to merge 4 commits into from
Closed

group environment files into a folder #982

wants to merge 4 commits into from

Conversation

joshgubler
Copy link
Member

No description provided.

@joshgubler joshgubler force-pushed the yet-another-option branch 2 times, most recently from 46a280f to 9613071 Compare July 31, 2023 14:58
GaryGSC added 3 commits August 9, 2023 12:00
@GaryGSC
Flatten TF module structure via .tfvars/.tfbackend, update to TF …
3f569d1 
…v1.5.3
@GaryGSC
Make terraform init prompt for bucket name instead of defaulting to…
708b61d 
… local backend

This makes it harder to do the wrong thing. With this change, we avoid
a potential footgun when developers use `terraform init` instead of
`terraform init -backend-config=dev.s3.tfbackend`.

This isn't a functional change because we were already using encryption
on everything in our state buckets.
@GaryGSC
Fix Dependabot path to TF, also get TF provider updates
7602118
@GaryGSC GaryGSC force-pushed the simplify-tf-module-structure branch from dd4d37a to 7602118 Compare August 9, 2023 18:02
@joshgubler joshgubler marked this pull request as ready for review August 11, 2023 16:20
@joshgubler joshgubler changed the base branch from simplify-tf-module-structure to dev August 11, 2023 16:21
@github-actions
Copy link

Terraform Plan:

will create 60 resources:

  • aws_dynamodb_table - my_dynamo_table
  • aws_iam_policy - my_dynamo_policy
  • aws_iam_policy - my_s3_policy
  • aws_s3_bucket - my_s3_bucket
  • aws_s3_bucket - my_s3_bucket_logs
  • aws_s3_bucket_lifecycle_configuration - my_s3_bucket
  • aws_s3_bucket_lifecycle_configuration - my_s3_bucket_logs
  • aws_s3_bucket_logging - my_s3_bucket
  • aws_s3_bucket_public_access_block - default
  • aws_s3_bucket_public_access_block - default_logs
  • aws_s3_bucket_server_side_encryption_configuration - my_s3_bucket
  • aws_s3_bucket_server_side_encryption_configuration - my_s3_bucket_logs
  • aws_s3_bucket_versioning - my_s3_bucket
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_listener - test_listener
  • aws_alb_target_group - blue
  • aws_alb_target_group - green
  • aws_appautoscaling_policy - down
  • aws_appautoscaling_policy - up
  • aws_appautoscaling_target - default
  • aws_cloudwatch_log_group - container_log_group
  • aws_cloudwatch_metric_alarm - down
  • aws_cloudwatch_metric_alarm - up
  • aws_codedeploy_app - app
  • aws_codedeploy_deployment_group - deploymentgroup
  • aws_ecs_cluster - new_cluster
  • aws_ecs_service - service
  • aws_ecs_task_definition - task_def
  • aws_iam_policy - secrets_access
  • aws_iam_role - task_execution_role
  • aws_iam_role - task_role
  • aws_iam_role_policy_attachment - secret_task_policy_attach
  • aws_iam_role_policy_attachment - secrets_policy_attach
  • aws_iam_role_policy_attachment - task_execution_policy_attach
  • aws_iam_role_policy_attachment - task_policy_attach
  • aws_iam_role_policy_attachment - task_policy_attach
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - fargate_service_sg
  • local_file - appspec_json
  • aws_cloudwatch_log_group - lambda_logs
  • aws_iam_policy - s3_access
  • aws_iam_role - test_lambda
  • aws_iam_role_policy - test_lambda
  • aws_iam_role_policy_attachment - s3_access
  • aws_lambda_function - test_lambda
  • aws_s3_bucket - postman_bucket
  • aws_s3_bucket - postman_bucket_logs
  • aws_s3_bucket_lifecycle_configuration - postman_bucket
  • aws_s3_bucket_lifecycle_configuration - postman_bucket_logs
  • aws_s3_bucket_logging - postman_bucket
  • aws_s3_bucket_public_access_block - default
  • aws_s3_bucket_public_access_block - default_logs
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket_logs
  • aws_s3_object - collections
  • aws_s3_object - environments

will delete 59 resources:

  • aws_dynamodb_table - my_dynamo_table
  • aws_iam_policy - my_dynamo_policy
  • aws_iam_policy - my_s3_policy
  • aws_s3_bucket - my_s3_bucket
  • aws_s3_bucket - my_s3_bucket_logs
  • aws_s3_bucket_lifecycle_configuration - my_s3_bucket
  • aws_s3_bucket_lifecycle_configuration - my_s3_bucket_logs
  • aws_s3_bucket_logging - my_s3_bucket
  • aws_s3_bucket_public_access_block - default
  • aws_s3_bucket_public_access_block - default_logs
  • aws_s3_bucket_server_side_encryption_configuration - my_s3_bucket
  • aws_s3_bucket_server_side_encryption_configuration - my_s3_bucket_logs
  • aws_s3_bucket_versioning - my_s3_bucket
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_listener - test_listener
  • aws_alb_target_group - blue
  • aws_alb_target_group - green
  • aws_appautoscaling_policy - down
  • aws_appautoscaling_policy - up
  • aws_appautoscaling_target - default
  • aws_cloudwatch_log_group - container_log_group
  • aws_cloudwatch_metric_alarm - down
  • aws_cloudwatch_metric_alarm - up
  • aws_codedeploy_app - app
  • aws_codedeploy_deployment_group - deploymentgroup
  • aws_ecs_cluster - new_cluster
  • aws_ecs_service - service
  • aws_ecs_task_definition - task_def
  • aws_iam_policy - secrets_access
  • aws_iam_role - task_execution_role
  • aws_iam_role - task_role
  • aws_iam_role_policy_attachment - secret_task_policy_attach
  • aws_iam_role_policy_attachment - secrets_policy_attach
  • aws_iam_role_policy_attachment - task_execution_policy_attach
  • aws_iam_role_policy_attachment - task_policy_attach
  • aws_iam_role_policy_attachment - task_policy_attach
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - fargate_service_sg
  • aws_cloudwatch_log_group - lambda_logs
  • aws_iam_policy - s3_access
  • aws_iam_role - test_lambda
  • aws_iam_role_policy - test_lambda
  • aws_iam_role_policy_attachment - s3_access
  • aws_lambda_function - test_lambda
  • aws_s3_bucket - postman_bucket
  • aws_s3_bucket - postman_bucket_logs
  • aws_s3_bucket_lifecycle_configuration - postman_bucket
  • aws_s3_bucket_lifecycle_configuration - postman_bucket_logs
  • aws_s3_bucket_logging - postman_bucket
  • aws_s3_bucket_public_access_block - default
  • aws_s3_bucket_public_access_block - default_logs
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket_logs
  • aws_s3_object - collections
  • aws_s3_object - environments

see details

@joshgubler joshgubler changed the base branch from dev to simplify-tf-module-structure August 11, 2023 16:23
@GaryGSC GaryGSC force-pushed the simplify-tf-module-structure branch 2 times, most recently from f27ecde to 0bc6d66 Compare June 24, 2024 22:02
@GaryGSC
Copy link
Member

GaryGSC commented Jul 5, 2024

Closing in favor of #1247

@GaryGSC GaryGSC closed this Jul 5, 2024
@GaryGSC GaryGSC deleted the yet-another-option branch July 5, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgubler @GaryGSC