Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for PHP 8.0 and updated minimal php version to 7.3 #212

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

EJTJ3
Copy link
Contributor

@EJTJ3 EJTJ3 commented Apr 6, 2021

This PR closes/fixes the following issues:

@EJTJ3 EJTJ3 marked this pull request as ready for review April 6, 2021 21:06
@EJTJ3 EJTJ3 changed the title bunq/sdk_php#211 BREAKING CHANGE updated minimal php version and depe… BREAKING CHANGE updated minimal php version and depe… Apr 7, 2021
@basepack
Copy link

basepack commented Sep 9, 2021

Is this commit still being worked on?

@EJTJ3
Copy link
Contributor Author

EJTJ3 commented Sep 10, 2021

Looks like this repository is no longer maintained.

@HVSoftware
Copy link

@EJTJ3 I see you have made an MR which support the latets version of PHP. I also want to use this feature. Would it be an option to spilt the issue into multiple MR's. Like update to PHP 7.4, followed by an MR to update to PHP 7.4 and 8.0? Maybe when the changes are smaller the MR can be accapted faster.

@EJTJ3
Copy link
Contributor Author

EJTJ3 commented Sep 10, 2021

@HVSoftware I've updated the minimal php version to 7.3 to keep the changes as small as possible. The problem is that bunq no longer actively maintains its repositories.

@basepack
Copy link

@EJTJ3 Thanks for that! But do you know the reason why bunq does not maintain them anymore?

@HVSoftware
Copy link

Don't know why they don't maintain the repository anymore. I have sent them an email. Otherwise I try to contact them in a different way.

@EJTJ3 EJTJ3 changed the title BREAKING CHANGE updated minimal php version and depe… Enhancement: Add support for PHP 8.0 and updated minimal php version to 7.3 Sep 11, 2021
@HVSoftware
Copy link

I've received a mail from the support department. They will delegate the request to the correct department.

@EJTJ3
Copy link
Contributor Author

EJTJ3 commented Oct 6, 2021

Did you hear anything from Bunq?

@bunq-bot bunq-bot merged commit 071183f into bunq:develop Oct 12, 2021
@basepack
Copy link

@HVSoftware did you receive any news from Bunq?

@HVSoftware
Copy link

@basepack They just merged the PR.

@basepack
Copy link

@HVSoftware yes I saw that, but I thought maybe you now also got the reason why they do not maintain this repo. Because to quote myself: "But do you know the reason why bunq does not maintain them anymore?"

And to quote your reaction later: "Don't know why they don't maintain the repository anymore. I have sent them an email. Otherwise I try to contact them in a different way."

So I thought maybe you now know why they do not maintain it anymore?

@HVSoftware
Copy link

@basepack I did not received a clear reason why there was no maintenance done anymore on this repository since the last months. I've send them a mail and ask the why question. I will keep you updated when I receive more information.

@EJTJ3
Copy link
Contributor Author

EJTJ3 commented Oct 15, 2021

@HVSoftware Thanks!
I hope @bunq-bot will release a new version soon!

@HVSoftware
Copy link

@EJTJ3 I have sent them a request by email to release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add support for PHP 8.0 and updated minimal php version to 7.3
4 participants