refactor: changed transaction handling related to OpsEvent package #1484
+228
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Changed the transaction instance of
OpsCountStorageto be controlled viamysqlClient.Qe().Also, this pull request introduces significant updates to the
AutoOpsServicein thepkg/autoops/api/api.gofile, focusing on the refactoring of storage dependencies. The main changes involve replacing inline storage initializations with pre-initialized storage fields within theAutoOpsServicestruct. Additionally, corresponding test updates have been made to accommodate these changes.By doing so, you can mock Storage in your test code, resulting in more meaningful test code.
Part of #1252