feat: update goal REST no command #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvn2k1
force-pushed
the
update-goal-no-cmd
branch
from
098121c to
c6e41af
Compare
cre8ivejp
reviewed
Jan 21, 2025
pkg/experiment/domain/goal.go
Outdated
Comment on lines
65
to
67
| if deleted != nil { | ||
| updated.Goal.Deleted = deleted.Value | ||
| } |
There was a problem hiding this comment.
If the goal is not in use, we can delete it from the table. There is no need to do a soft delete.
hvn2k1
force-pushed
the
update-goal-no-cmd
branch
from
395dfdd to
d2453c7
Compare
cre8ivejp
reviewed
Jan 21, 2025
pkg/experiment/domain/goal.go
Outdated
| name *wrapperspb.StringValue, | ||
| description *wrapperspb.StringValue, | ||
| archived *wrapperspb.BoolValue, | ||
| deleted *wrapperspb.BoolValue, |
There was a problem hiding this comment.
You can remove this since you are not using in the update API anymore.
Suggested change
| deleted *wrapperspb.BoolValue, |
There was a problem hiding this comment.
I have remove the redundant code!
hvn2k1
force-pushed
the
update-goal-no-cmd
branch
from
d2453c7 to
84e7fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1417