Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change environment_namespace variable name to environment_id #1457

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

Ubisoft-potato
Copy link
Collaborator

@Ubisoft-potato Ubisoft-potato commented Jan 16, 2025

Fix #884

This PR will change all variable name from environment namespace to environment id.

Also we should update Grafana dashboard metrics config:

@Ubisoft-potato Ubisoft-potato marked this pull request as ready for review January 16, 2025 06:18
hack/create-api-key/command.go Outdated Show resolved Hide resolved
test/e2e/account/account_test.go Outdated Show resolved Hide resolved
test/e2e/autoops/auto_ops_test.go Outdated Show resolved Hide resolved
test/e2e/environment/environment_v2_test.go Outdated Show resolved Hide resolved
test/e2e/eventcounter/eventcounter_test.go Outdated Show resolved Hide resolved
test/e2e/feature/feature_test.go Outdated Show resolved Hide resolved
test/e2e/gateway/api_grpc_test.go Outdated Show resolved Hide resolved
test/e2e/notification/subscription_test.go Outdated Show resolved Hide resolved
test/e2e/push/push_test.go Outdated Show resolved Hide resolved
test/e2e/tag/tag_test.go Outdated Show resolved Hide resolved
@cre8ivejp cre8ivejp merged commit bc380eb into main Jan 20, 2025
22 checks passed
@cre8ivejp cre8ivejp deleted the chore-rename-variable branch January 20, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: migrate from environment_namespace to environment_id
2 participants