refactor: change the method of specifying query conditions #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
requested review from
Ubisoft-potato and
hvn2k1
and removed request for
kentakozuka
hvn2k1
reviewed
Dec 27, 2024
| ) ([]*proto.AutoOpsRule, int, error) { | ||
| var whereParts []mysql.WherePart = []mysql.WherePart{} | ||
| var orderBySQL string = "" |
There was a problem hiding this comment.
Zero value of string and int are "" and 0 already, so I think there won't be necessary to declare the value here! But if you want it to be clear for everyone, I think it's ok to keep it, I want to know your opinion 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring to improve the handling of query filters and options in the
AutoOpsServiceand related storage components. The changes focus on replacing the existingWherePartandOrderstructures with a more flexibleListOptionsstructure, which encapsulates various filter types and query options.Part of #1252