Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocfDeviceType and vid fields #132

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

deiger
Copy link

@deiger deiger commented Dec 9, 2018

Needed to support the new Smartthings app.

@veeceeoh
Copy link
Collaborator

Can you guarantee these changes will work for all SmartThings users?

SmartThings still does not officially support custom DTHs in the new SmartThings app, and users are only guessing what lines need to be added to get devices with custom DTHs to work in the new mobile app.

These guesses are not always successful, as evidenced by this thread on the ST Community forums:

https://community.smartthings.com/t/new-app-which-custom-dth-s-will-work/133908

@deiger
Copy link
Author

deiger commented Dec 10, 2018

As stated in the link you provided, devices with custom DTH always appear in the new SmartThings app. They are just not usable without these additional fields.
I cannot say for certain that this will work for all users, but for me they work. That's the reason I only changed these 3 DTHs, as they are the only ones I currently have and could test.
Moreover, I paired the smoke detector with the new app, and it attached the correct DTH by itself. Even if these do not work for someone, I'm not sure how this could be worse than the current situation of totally unusable devices.

@cscheiene
Copy link

@deiger How did you create a custom VID and got it working? Tried to create one for a Netatmo device in the new dev portal but it does not work. I tried to use yours and it works, but I need to add some more capabilities for my device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants