Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tags to test compatibility with the new SmartThings app #126

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mssaleh
Copy link

@mssaleh mssaleh commented Oct 4, 2018

I am not sure if these tags are enough, but I'd like to test them with the new app.

@veeceeoh
Copy link
Collaborator

veeceeoh commented Oct 9, 2018

Hi. Thanks for the contribution.

You don't actually need to submit a pull request to do this kind of testing. Just change the code in your local copy of the DTH in your IDE, and try it out on your mobile device with the new ST app.

Personally I am not using the new mobile app and don't plan to until official support has been announced for third party DTHs. It wouldn't make sense to commit this pull request until it's been thoroughly tested.

Please feel to share the pull request modifications with folks on the ST community forums in order to get more people testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants