Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More boolean ops for Face and CompoundFace #195

Merged
merged 2 commits into from
Jan 19, 2025
Merged

More boolean ops for Face and CompoundFace #195

merged 2 commits into from
Jan 19, 2025

Conversation

mkovaxx
Copy link
Collaborator

@mkovaxx mkovaxx commented Jan 16, 2025 •
edited
Loading

Face has union and subtract. Adding intersect, so that e.g. symmetric difference may be computed. Also adding boolean ops for CompoundFace.

@mkovaxx mkovaxx self-assigned this Jan 16, 2025
@mkovaxx mkovaxx requested a review from bschwind January 16, 2025 16:50
@mkovaxx mkovaxx changed the title Add fn Face::intersect(&self, &Face) -> CompoundFace Intersect Faces to get a CompoundFace Jan 16, 2025
bschwind
bschwind approved these changes Jan 18, 2025
View reviewed changes
Copy link
Owner

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a draft, is there anything else you wanted to add?

@mkovaxx
Copy link
Collaborator Author

mkovaxx commented Jan 18, 2025

LGTM! This is a draft, is there anything else you wanted to add?

Yep, I think it'd be good to expose the same CSG methods (union, intersect, subtract) on CompoundFace itself.

What do you think?

@bschwind
Copy link
Owner

Ohhh yep, if it's as straightforward as this one was then let's add it too.

@mkovaxx mkovaxx changed the title Intersect Faces to get a CompoundFace More Face and CompoundFace boolean ops Jan 18, 2025
@mkovaxx mkovaxx changed the title More Face and CompoundFace boolean ops More boolean ops for Face and CompoundFace Jan 18, 2025
@mkovaxx mkovaxx marked this pull request as ready for review January 18, 2025 20:48
@mkovaxx mkovaxx requested a review from bschwind January 18, 2025 20:48
bschwind
bschwind approved these changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bschwind bschwind merged commit 6042964 into bschwind:main Jan 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwind bschwind bschwind approved these changes

Assignees

@mkovaxx mkovaxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkovaxx @bschwind