Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quartiles, interquartiles and outliers functions #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanakenm
Copy link

Hi! Found your lib which was exactly what I needed - a small stats package with histogram support. I needed some support to remove outliers, so here is the PR.

I found some mix of "standard" function and fat arrow ones, I used the latter when possible but did not touch the rest. In order to stay in the same convention I did not use let/const.

Just realized I had prettier "on save" - if this is a problem I can easily revert (I just added the methods mentioned, I did not touch anything else).

@brycebaril
Copy link
Owner

Hi @vanakenm! I like the idea! Can you clean this up to not add all the semicolons in? It makes the diff a bit hard to read ;)

I've been slowly adding standard to my packages but I haven't gotten to this one yet. Apologies for no linter here to provide guidance.

@vanakenm
Copy link
Author

vanakenm commented May 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants