Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: absence of cli flags results in argparse passing explicit None #1636

Merged
merged 2 commits into from
Oct 1, 2024
+4 −4
Merged

bug: absence of cli flags results in argparse passing explicit None #1636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cde643d
bug: absence of cli flags results in argparse passing explicit None
sjahl Oct 1, 2024
72dfdf9
also don't try to delete reads svc since we don't manage that here an…
sjahl Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions deploy/deployctl/subcommands/ingress_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,12 @@ def apply_services(name: str, browser_deployment: str = None) -> None:
kubectl(["apply", "-f", "-"], input=manifest)


def apply_ingress(
name: str, browser_deployment: str = None, reads_service: str = "reads-bluegreen-active-prod"
) -> None:
def apply_ingress(name: str, browser_deployment: str = None, reads_service: str = None) -> None:
apply_services(name, browser_deployment)

if not reads_service:
reads_service = "reads-bluegreen-active-prod"

manifest = INGRESS_MANIFEST_TEMPLATE.format(name=name, reads_service=reads_service)

kubectl(["apply", "-f", "-"], input=manifest)
Expand All @@ -111,7 +112,6 @@ def apply_ingress(

def delete_ingress_and_services(name: str) -> None:
kubectl(["delete", f"ingress/gnomad-ingress-demo-{name}"])
kubectl(["delete", f"service/gnomad-reads-demo-{name}"])
kubectl(["delete", f"service/gnomad-browser-demo-{name}"])


Expand Down
Loading