Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move elasticsearch to deployments repo #1612

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Move elasticsearch to deployments repo #1612

merged 2 commits into from
Aug 22, 2024

Conversation

sjahl
Copy link
Contributor

@sjahl sjahl commented Aug 21, 2024

This removes the elasticsearch manifest templating and apply bits from deployctl, and moves them to https://github.com/broadinstitute/gnomad-deployments/tree/1b9bbf5455965b0c8777d160ace3ec88810641f8/elasticsearch

Note, the elasticsearch subcommand of deployctl isn't going away completely, since it still provides the load-dataset command that is separate from the kubernetes config side of elasticsearch. There's also a utility function in there for retrieving the ES password, and I believe that's also used somewhere in the data pipeline code.

The template and apply functionality that deployctl was giving us is largely replaced by:

kustomize init # to create new cluster configs
kustomize build # to view rendered templates
kustomize build prod | kubectl diff/appy -f - # to diff and apply configs

See the documentation in the deployments repo/elasticsearch readme for more info.

@sjahl sjahl self-assigned this Aug 21, 2024
@rileyhgrant rileyhgrant self-requested a review August 22, 2024 16:41
Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

With the one teeny and inconsequential comment that if you weren't going to squash these commits down, then the second one has a typo in it ('maniests' instead of 'manifests')

Thanks for continually keeping the docs up to date every time you change something!

@sjahl sjahl merged commit 054f00f into main Aug 22, 2024
4 checks passed
@sjahl sjahl deleted the move-elasticsearch branch August 22, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants