Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with broadinstitute/tgg-terraform-modules#39, update our deployctl config so that images are built and tagged with an artifact registry URL.
The intention is that each of our GCP projects will end up with a "gnomad" namespace / registry, with multiple images inside of it. So we'll have a
$LOCATION-docker.pkg.dev/$PROJECT/gnomad/gnomad-api
,$LOCATION-docker.pkg.dev/$PROJECT/gnomad/gnomad-browser
, etc.Note that one side effect of this change, is that you may need to add additional credential helper lines to your
~/.docker/config.json
to handle additional non-gcr.io URLs. See https://cloud.google.com/artifact-registry/docs/docker/pushing-and-pulling#cred-helperMy credHelpers config looks like