fix(secrets): Remove both random and base64 entropy secrets finding #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2025 15:34
… (in multiline policy) captured, so matching group will be the match & empty matching as only one pattern caught the secret
pazbechor
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
changed the title
tsmithv11
approved these changes
Jan 24, 2025
ChanochShayner
approved these changes
Jan 26, 2025
|
Great work @pazbechor ! Do we have any relevant tests that needs to be changed/added? |
…ndom-and-base64-entropy
pazbechor
temporarily deployed
to
scan-security
GitHub Actions
Inactive
pazbechor
temporarily deployed
to
scan-security
GitHub Actions
Inactive
pazbechor
temporarily deployed
to
scan-security
GitHub Actions
Inactive
Saarett
pushed a commit
that referenced
this pull request
Feb 3, 2025
…6969) * fix a bug where multiple regex are being supplied seperated by | sign (in multiline policy) captured, so matching group will be the match & empty matching as only one pattern caught the secret * adding the fix. Should be merged only after merging this PR #6967 * . * . --------- Co-authored-by: pazbechor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Modifies the handling of high entropy secrets detection in the
checkov/secrets/runner.pyfile. Introduces logic to prioritize Random High Entropy checks over Base64 High Entropy checks when both are detected on the same line. This change aims to reduce false positives and improve the accuracy of secret detection.Modified files (1)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)