Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-9391 As an Instance Administrator, I want to configure captcha on instance level #158454

Closed
wants to merge 24 commits into from
Closed

LPD-9391 As an Instance Administrator, I want to configure captcha on instance level #158454

wants to merge 24 commits into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-appsec#2187 (Took 4 ci:forward attempts in 15 hours 46 minutes)
Console

@liferay-appsec

Original pull request comment:
Ticket: https://liferay.atlassian.net/browse/LPD-9391

istvansajtos and others added 24 commits February 3, 2025 18:33
@istvansajtos @rafaprax
LPD-9391 Make Captcha configurable at instance level
4076d3c
@istvansajtos @rafaprax
LPD-9391 Update usages
c3d1c0b
@istvansajtos @rafaprax
LPD-9391 Add test
2fccc0c
@ChrisKian @rafaprax
LPD-9391 SF - Not needed since we already include a throws clause for…
0aff8b1 
… it's parent class
@ChrisKian @rafaprax
LPD-9391 Remove need to add new methods as well as any uses of portle…
cc9a0fe 
…tRequest
@ChrisKian @rafaprax
LPD-9391 Move the logic to retrieve the CaptchaConfiguration to the C…
d3e65e6 
…aptchaProvider so we can avoid the changes on the CaptchaUtil class, update usages, and use CompanyThreadLocal#getCompanyId instead of the PortalUtil#getCompanyId.
@ChrisKian @rafaprax
LPD-9391 Remove configurationPid from the Component annotation since …
0ac2cd0 
…we are using the ConfigutationProvider api to retrieve the CaptchaConfiguration now.
@ChrisKian @rafaprax
LPD-9391 SF fix typo
a60b83f
@ChrisKian @rafaprax
LPD-9391 SF extract reusable code to private method
8b3536f
@ChrisKian @rafaprax
LPD-9391 Allow CaptchaProvider to easily return configuration
62c22a5
@ChrisKian @rafaprax
LPD-9391 Get the configuration from CaptchaProvider, which will retri…
f24ef7a 
…eve the config from the ConfigurationProvider class. This will allow for instance and SYSTEM level configurations to be used correctly.
@daiazius @rafaprax
LPD-9391 SF Change year
34d1ebb
@daiazius @rafaprax
LPD-9391 SF
96d8dbf
@daiazius @rafaprax
LPD-9391 Apply to other usages
abc1c9b
@daiazius @rafaprax
LPD-9391 Semver
95c7160 
# breaking

## What modules/apps/captcha/captcha-api/bnd.bnd

Moved captcha configuration from System to Instance level

## Why

Required to allow Instance Administrators to configure captcha on instance level

----
@daiazius @rafaprax
LPD-9391 Update CaptchaConfigPage goTo
9e1898f
@daiazius @rafaprax
LPD-9391 Use exception instead since we are dealing with checked exce…
a10956b 
…ptions in this block
@daiazius @rafaprax
LPD-9391 Remove check so the configuration is always updated when cal…
e50249a 
…led, to ensure the object doesn't get stale
@daiazius @rafaprax
LPD-9391 SF Avoid chaining methods
1e9a8be
@rafaprax
LPD-9391 Use the ConfigurationProvider instead of ConfigurationProvid…
207c228 
…erUtil and handle configuration exception into the getCaptchaConfiguration method
@rafaprax
LPD-9391 Use captchaProvider.getCaptchaConfiguration() directly
f2c5bb5
@rafaprax
LPD-9391 Not needed
c51a41c
@rafaprax
LPD-9391 SF
c062731
@rafaprax
LPD-9391 Rename method and unify test cases
12295c9
@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bbc1dec12d55a4d4fa32a8ebf79e13d04fb7e315

Sender Branch:

Branch Name: captcha-rev
Branch GIT ID: 12295c9a31929de73e0f3889998759d522c33970

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bbc1dec12d55a4d4fa32a8ebf79e13d04fb7e315

Upstream Comparison:

Branch GIT ID: bbc1dec12d55a4d4fa32a8ebf79e13d04fb7e315
Jenkins Build URL: EE Development Acceptance (master) - 1166 - 2025-02-03[12:38:16]

ci:test:stable - 24 out of 24 jobs PASSED
24 Successful Jobs:
    ci:test:relevant - 29 out of 32 jobs PASSED

    3 Failed Jobs:

    29 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. modules-integration-mysql57/0/0
        stop-docker-containers:
     [exec] Stopping container [ID: 'cc29313cee0e', name: 'test-1-29-54.lax.liferay.com_mysql']'
     [exec] test-1-29-54.lax.liferay.com_mysql
     [exec] test-1-29-54.lax.liferay.com_mysql
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/docker_stop.sh
[stopwatch] [run.batch.test.action: 22:35.153 sec]
     [echo] 
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null821502092.properties
        1. com.liferay.message.boards.search.test.MBThreadMultiLanguageSearchTest.testChineseSubject - UNTESTED
        2. com.liferay.message.boards.search.test.MBThreadMultiLanguageSearchTest.testEnglishSubject - UNTESTED
        3. com.liferay.message.boards.search.test.MBThreadMultiLanguageSearchTest.testJapaneseSubject - UNTESTED
        4. ...

      For upstream results, click here.

      @liferay-continuous-integration liferay-continuous-integration mentioned this pull request Feb 4, 2025
      Closed
      @rafaprax
      Copy link

      rafaprax commented Feb 5, 2025

      ci:close

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers
      No reviews
      Assignees
      No one assigned
      Labels
      None yet
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      5 participants
      @liferay-continuous-integration @rafaprax @istvansajtos @ChrisKian @daiazius