LPD-44159 Rework data set serialization (actions) #158439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data sets, with unit tests # breaking ## What modules/apps/frontend-data-set/frontend-data-set-api/src/main/java/com/liferay/frontend/data/set/action/FDSCreationMenu.java deleted method * public CreationMenu getCreationMenu(HttpServletRequest httpServletRequest, HttpServletResponse httpServletResponse) throws PortalExceptionn added method * public CreationMenu getCreationMenu(HttpServletRequest httpServletRequest) ## Why httpServletResponse is not necessary to compute the creation menu. Also, we want implementations to handle their exceptions and return an empty menu if something goes wrong, so that the serialization does not stop. This is a recently added interface, not yet implemented. Customers are not affected at the time of this writing ----
…tem data sets, with unit tests # breaking ## What modules/apps/frontend-data-set/frontend-data-set-api/src/main/java/com/liferay/frontend/data/set/action/FDSItemActionList.java deleted method * public List<FDSActionDropdownItem> getFDSActionDropdownItems(HttpServletRequest httpServletRequest, HttpServletResponse httpServletResponse) throws PortalException added method * public List<FDSActionDropdownItem> getFDSActionDropdownItems(HttpServletRequest httpServletRequest); ## Why httpServletResponse is not necessary to compute the item action list. Also, we want implementations to handle their exceptions and return an empty list if something goes wrong, so that the serialization does not stop. This is a recently added interface, not yet implemented. Customers are not affected at the time of this writing ----
…ts, with unit tests. Custom data sets don't yet support definition of bulk actions so we provide a placeholder implementation to facilitate reference handling in the renderer
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
This was referenced Feb 4, 2025
|
see #158467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #158397 with some naming improvements.
SF and tests pass locally