Changes towards general TBD solution #1
Conversation
| # | ||
| # lib/openstudio-standards/btap/bridging.rb | ||
| # | ||
| # Otherwise, :bad vs :good PSI factor sets refer to costed BTAP details. |
There was a problem hiding this comment.
Boils down to a single TBD parameter.
| @@ -1265,13 +1265,11 @@ def initialize(model = nil, argh = {}) | |||
| comply = false | |||
| redflag = false | |||
| perform = :lp # Low-performance wall constructions | |||
| quality = :bad # poor PSI factors | |||
| quality = :bad # poor PSI factors - maybe reset to :good (user option) | |||
| quality = :good if argh.key?(:quality) && argh[:quality] == :good | |||
There was a problem hiding this comment.
When BTAP users opt to NOT uprate, but instead run cases while setting PSI factor quality (:poor vs :bad) - reset BEFORE setting the combo variable (i.e. TBD JSON Hash).
| @@ -1340,6 +1339,8 @@ def initialize(model = nil, argh = {}) | |||
| break if unable | |||
|
|
|||
| unable = log[:message].include?("Can't uprate " ) | |||
|
|
|||
| # Maybe check for FATAL errors logged by TBD ... TO-DO. | |||
There was a problem hiding this comment.
TBD will catch FATAL and non-fatal ERROR messages (critical to its own internal calculations) that aren't necessarily caught by OpenStudio, but usually caught by EnergyPlus. Here, TBD only red-flags cases it can't uprate (and then takes step accordingly). TBD could also catch FATAL errors beforehand. Or alternatively let EnergyPlus halt a simulation in such cases. Up to BTAP Team.
| # puts | ||
| # puts "#{id} : #{stypes} : #{group[:uo]}: #{group[:faces].size}x" | ||
| # group[:faces].each { |s| puts s.nameString } | ||
| sss = BTAP::Geometry::Surfaces.set_surfaces_construction_conductance(group[:faces], group[:uo]) |
There was a problem hiding this comment.
When BTAP users request 'uprating' (e.g. NECB2017, NECB2020) yet TBD fails to identify a winning Uo + PSI factor combo to meet the Ut target. Such cases are non-compliant, yet the code here nonetheless resets (in batches) construction Uo factors to the lowest (i.e. best performing) BTAP 'costed' option (e.g. 0.100 or 0.080 W/K.m^2 for walls). TBD ultimately derates the same constructions. This provides a ball-park figure of effort (
| mdl.addObjects(model.toIdfFile.objects) | ||
| TBD.clean! | ||
| res = TBD.process(mdl, args) | ||
| surfaces = res[:surfaces] |
There was a problem hiding this comment.
Running a 'dry-run' TBD instance is more efficient for validating and gathering key inputs from the OpenStudio model (than duplicating a lot of the same code).
| # Add final selection of (uprated) Uo factors per BTAP construction. | ||
| return true unless @model.key?(:constructions) | ||
|
|
||
| @tally[:constructions] = @model[:constructions] |
There was a problem hiding this comment.
tally now holds a Hash of edges (i.e. thermal bridges), as well as uprated constructions (if applicable).
| # temporarily mistaken as a conditioned plenum. The return variable of the | ||
| # following method is a Hash holding temporarily-modified spaces, | ||
| # i.e. buffer zones. | ||
| buffers = self.alter_buffers(model) |
There was a problem hiding this comment.
Temporary solution to fix attic vs plenum mixup in BTAP.
| # @param tbd_option [String] BTAP/TBD option | ||
| # | ||
| # @return [Bool] true if successful, e.g. no errors, compliant if uprated | ||
| def apply_thermal_bridging(model: nil, tbd_option: 'none') |
There was a problem hiding this comment.
Moves BTAP/TBD processes after resetting FWDR & SRR.
| fdback << log | ||
|
|
||
| # NOTE: BTAP/TBD feedback logs are simple strings. Look up | ||
| # st.tbd.tally Hash to extract quantities for costing. |
No description provided.