Skip to content

Commit

Permalink
Remove XXX and TODO markers
Browse files Browse the repository at this point in the history
  • Loading branch information
brettcannon committed Jul 24, 2021
1 parent 5933cf9 commit 4eb285c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ impl Action {
})
}
}
// TODO: Figure out how to store the result of the version_from_flag() call.
Some(version) if version_from_flag(version).is_some() => {
Ok(Action::Execute {
launcher_path,
Expand Down Expand Up @@ -211,7 +210,6 @@ fn relative_venv_path(add_default: bool) -> PathBuf {
/// existence of the `VIRTUAL_ENV` environment variable.
fn venv_executable_path(venv_root: &str) -> PathBuf {
PathBuf::from(venv_root).join(relative_venv_path(false))
// XXX: Do a is_file() check first?
}

fn activated_venv() -> Option<PathBuf> {
Expand Down
3 changes: 0 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ impl Display for RequestedVersion {
impl FromStr for RequestedVersion {
type Err = Error;

// XXX Require `python` as a prefix?
fn from_str(version_string: &str) -> Result<Self> {
if version_string.is_empty() {
Ok(Self::Any)
Expand Down Expand Up @@ -307,8 +306,6 @@ impl ExactVersion {
})
}

// XXX from_shebang()?

/// Tests whether this [`ExactVersion`] satisfies the [`RequestedVersion`].
///
/// # Examples
Expand Down
2 changes: 0 additions & 2 deletions tests/common/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ impl EnvVarState {
}
}

// XXX This attribute shouldn't be needed; side-effect of only being used in tests?
#[allow(dead_code)]
pub fn empty() -> Self {
let mut state = Self::new();
Expand Down Expand Up @@ -63,7 +62,6 @@ impl Drop for CurrentDir {
}

impl CurrentDir {
// XXX This attribute shouldn't be needed; side-effect of only being used in tests?
#[allow(dead_code)]
pub fn new() -> Self {
let _original_dir = env::current_dir().unwrap();
Expand Down

0 comments on commit 4eb285c

Please sign in to comment.