Skip to content

Commit

Permalink
Merge pull request #123 from AnggieAlava/bug/1505
Browse files Browse the repository at this point in the history
Corregido los readmes para evitar confusiones respecto al bg o border
  • Loading branch information
tommygonzaleza authored Feb 29, 2024
2 parents a7e387d + e3b5547 commit d594484
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
11 changes: 8 additions & 3 deletions .learn/exercises/11.1-header-content/README.es.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ En el diseño que debemos realizar, el `postcard-header` tiene un título a la i

1. Agrega un tag `<h1>` dentro del contenido de `.postcard-header`, cuyo texto debe ser **"My Postcard"** (asegúrate de que el **h1** contenga el título deseado para el postcard).

2. Agrega un tag `<img>` dentro del mismo `<div>`. La **imagen** y el **h1** deben ser hermanos (hijos inmediatos del `.postcard-header`)
2. Agrega un tag `<img>` dentro del mismo `<div>`. La **imagen** y el **h1** deben ser hermanos (hijos inmediatos del `.postcard-header`)

3. Haz que la imagen tenga este URL:

Expand All @@ -20,6 +20,11 @@ https://raw.githubusercontent.com/breatheco-de/exercise-postcard/e63a7916530cc85

## Resultado Esperado:

+ Si le haces `build` a tu página, debería verse así:
- Si le haces `build` a tu página, debería verse así:

![Header Content Preview](../../assets/header-content.png?raw=true)
![Header Content Preview](../../assets/header-content.png?raw=true)


## 💡 Pista:

- No olvides que el **fondo negro** y el **borde rojo** solo son guías temporales para diferenciar mejor nuestros componentes, no te concentres en ellos, serán removidos al final.
13 changes: 9 additions & 4 deletions .learn/exercises/11.1-header-content/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ tutorial: https://www.youtube.com/watch?v=7sFt2ztayBE

Now it is time to include our content inside the `.postcard-header` div.

The `postcard-header` contains one title on the left and one image on the right.
The `postcard-header` contains one title on the left and one image on the right.

What HTML `<tags>` do you think we should use to represent a title and an image? 🤔

Expand All @@ -16,13 +16,18 @@ What HTML `<tags>` do you think we should use to represent a title and an image?

2. Add a `<img>` tag inside the same `<div>`, the **image** and the **h1** must be siblings (immediate children of the `.postcard-header`)

3. Make the image have this URL:
3. Make the image have this URL:

```text
https://raw.githubusercontent.com/breatheco-de/exercise-postcard/e63a7916530cc850bd92aa1c2e19191837fb5c80/.learn/assets/4geeks.png
```

## Expected Result:

+ If you `build` your page, it should look like this:
- If you `build` your page, it should look like this:

![Header Content Preview](../../assets/header-content.png?raw=true)

## 💡 Hint:

![Header Content Preview](../../assets/header-content.png?raw=true)
- Don't forget that the **black background** and **red border** are only temporary guides to better differentiate our components, don't focus on them, they will be removed later.

0 comments on commit d594484

Please sign in to comment.