Exposes categories to the main action #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thypon
requested review from
bridiver,
diracdeltas,
ShivanKaul and
stoletheminerals
thypon
force-pushed
the
features/needs-security-label-only-with-security-category
branch
from
e9ce1a9 to
302ed5f
Compare
diracdeltas
reviewed
Dec 6, 2024
| @@ -7,7 +7,8 @@ rules: | |||
| - https://cwe.mitre.org/data/definitions/615 | |||
| - https://btlr.dev/blog/how-to-find-vulnerabilities-in-code-bad-words | |||
| confidence: LOW | |||
| source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/services/svelte-purifyConfig-usages.yaml | |||
| source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/services/svelte-purifyConfig-usage.yaml | |||
diracdeltas
approved these changes
Dec 6, 2024
thypon
deleted the
features/needs-security-label-only-with-security-category
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allow to decide which finding should be marked to have a
needs-security-labelor not.In the future we might expand this capability to have specific labels for findings.