Move package.json to root. #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
force-pushed
the
package-json-to-root
branch
from
554cf63 to
10e3e11
Compare
atuchin-m
reviewed
Apr 8, 2024
| @@ -10,9 +10,6 @@ on: | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
I believe have to change: on: trigger above.
Otherwise package.json changes could break /src tests.
|
Please merge in the same time with https://github.com/brave/finch-data-private/pull/7 |
atuchin-m
approved these changes
Apr 8, 2024
goodov
force-pushed
the
package-json-to-root
branch
from
6a382d4 to
25655c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brave-variationsshould supportnpm run lint/formatat the top level to allow working with study files natively.This PR changes the location of
package.jsonto allow this.