Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump express from 4.18.2 to 4.19.2 in /src #972

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Bump express from 4.18.2 to 4.19.2 in /src #972

merged 1 commit into from
Apr 9, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 26, 2024

Bumps express from 4.18.2 to 4.19.2.

Release notes

Sourced from express's releases.

4.19.2

What's Changed

Full Changelog: expressjs/express@4.19.1...4.19.2

4.19.1

What's Changed

Full Changelog: expressjs/express@4.19.0...4.19.1

4.19.0

What's Changed

New Contributors

Full Changelog: expressjs/express@4.18.3...4.19.0

4.18.3

Main Changes

Other Changes

... (truncated)

Changelog

Sourced from express's changelog.

4.19.2 / 2024-03-25

  • Improved fix for open redirect allow list bypass

4.19.1 / 2024-03-20

  • Allow passing non-strings to res.location with new encoding handling checks

4.19.0 / 2024-03-20

4.18.3 / 2024-02-29

Commits
  • 04bc627 4.19.2
  • da4d763 Improved fix for open redirect allow list bypass
  • 4f0f6cc 4.19.1
  • a003cfa Allow passing non-strings to res.location with new encoding handling checks f...
  • a1fa90f fixed un-edited version in history.md for 4.19.0
  • 11f2b1d build: fix build due to inconsistent supertest behavior in older versions
  • 084e365 4.19.0
  • 0867302 Prevent open redirect allow list bypass due to encodeurl
  • 567c9c6 Add note on how to update docs for new release (#5541)
  • 69a4cf2 deps: [email protected]
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by wesleytodd, a new releaser for express since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump express from 4.18.2 to 4.19.2 in /src
5b7f169 
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

[puLL-Merge] - expressjs/[email protected]

Description

This pull request introduces several significant updates and improvements to the Express.js framework. These changes span across updating CI workflows, enhancing security controls, expanding coverage for Node.js versions, updating dependencies, refining codebase for readability and security, adjusting project contributing guidelines, and bug fixes.

Changes

Changes

CI Workflow Changes (.github/workflows/ci.yml)

  • Added newer Node.js versions (19.x, 20.x, 21.x) to the CI testing matrix.
  • Updated Node.js versions to the latest minor releases for existing entries.
  • Updated actions/checkout to v4.
  • Added conditions to handle package-lock configurations during npm configuration.
  • Modified how npm module installations are handled for Node.js 8.x and 9.x.
  • Improved code coverage collection and upload mechanisms, including the use of actions/upload-artifact for better CI workflow.
  • Integrated lcov installation and coverage report merging for better reporting.

Contributing Guidelines Update (Contributing.md)

  • Introduced the role of Project Captain as the lead maintainer of a repository.
  • Expanded the definition and responsibilities of the Technical Committee (TC) and Project Captains.
  • Added detailed guidelines and process for nominating, adding, and transitioning TC members and Project Captains.
  • Outlined the nomination process and responsibilities for becoming a captain for project repositories.

Release Process Documentation (Release-Process.md)

  • Added steps to update the documentation website with the latest version number and change log updates.

Dependency and Version Updates (package.json)

  • Updated the express version to 4.19.2.
  • Updated various dependencies to their more recent versions including body-parser, cookie, ejs, and eslint among others.

Benchmarking Guide (benchmarks/README.md)

  • Added a new guide for conducting benchmarks using wrk.

Example Revisions (examples/)

  • Updated the README.md to reflect current examples and removed outdated multipart example.
  • Refinements to various example scripts for readability and simplicity.

Security Improvements and Bug Fixes

  • Addressed potential security hotspots by refining how the Location header is managed, ensuring proper encoding and handling of different types of inputs (lib/response.js).
  • Made several internal code adjustments to improve readability and maintain standards (e.g., spelling fixes, simplified conditional checks).

Security Hotspots

  • Switching to newer Node.js versions (CI Workflow): Ensuring the newer Node.js versions do not introduce compatibility or security issues with the current codebase or dependencies is crucial. While this addition is necessary for ensuring future compatibility, rigorous testing and monitoring for potential unexpected behaviors or vulnerabilities in newer runtime environments would be recommended.

  • Changes in Location Header Handling (lib/response.js): Changes in how the Location header is constructed, including how URL encoding is handled, introduces a critical area to watch for potential security implications, especially around open redirect vulnerabilities. While the changes aim to improve security, they necessitate thorough testing to ensure they don't inadvertently introduce new vulnerabilities.

  • Dependency Updates (package.json): Updating dependencies improves security by patching known vulnerabilities in older versions. However, it's essential to validate the updated dependencies' compatibility and check for any new vulnerabilities introduced.

@atuchin-m atuchin-m self-assigned this Apr 4, 2024
@atuchin-m atuchin-m requested a review from goodov April 4, 2024 13:42
@goodov goodov merged commit 739dc24 into main Apr 9, 2024
6 checks passed
@goodov goodov deleted the dependabot/npm_and_yarn/src/express-4.19.2 branch April 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov Awaiting requested review from goodov

Assignees

@atuchin-m atuchin-m

Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @atuchin-m