Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AdblockCustomScriptlets study. #1294

Closed
wants to merge 1 commit into from
Closed

Added AdblockCustomScriptlets study. #1294

wants to merge 1 commit into from
+31 −0

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Jan 13, 2025 •
edited
Loading

Resolves #1293

Original issue: brave/brave-core#25999

@boocmp boocmp self-assigned this Jan 13, 2025
@boocmp boocmp requested a review from a team as a code owner January 13, 2025 08:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1294.
    Android: Set the command line to --variations-pr=1294 in debug menu, restart the browser.
    iOS: Set Variations PR to 1294 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1294@b68bcf55e59838a15fcb6b04337dca562a406512
Uploaded Mon, 13 Jan 2025 08:20:24 GMT
PR commit 98a128a
Base commit 04e6ed4
Merge commit b68bcf5
Serial number 679154b8594dea7547e5151b455a6ebe

@boocmp boocmp closed this Jan 27, 2025
@boocmp boocmp deleted the issues/1293 branch January 27, 2025 06:42
@boocmp
Copy link
Contributor Author

boocmp commented Jan 27, 2025

We decided to enable the corresponding feature by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boocmp boocmp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adblock Custom Scriptlets in Nightly & Beta .
1 participant
@boocmp