Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeem Brave Ads confirmation tokens after 3 seconds #1265

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Redeem Brave Ads confirmation tokens after 3 seconds #1265

merged 1 commit into from
Nov 20, 2024
+41 −0

Conversation

tmancey
Copy link
Contributor

@tmancey tmancey commented Nov 19, 2024

@tmancey tmancey requested a review from a team as a code owner November 19, 2024 19:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1265.
    Android: Set the command line to --variations-pr=1265 in debug menu, restart the browser.
    iOS: Set Variations PR to 1265 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1265@168c4cc2ea0250eab377696dff8f9a863acef771
Uploaded Tue, 19 Nov 2024 22:37:24 GMT
PR commit cb81541
Base commit 3f13c37
Merge commit 168c4cc
Serial number 4fca2157363bfebdc6c9d5f10cfe276a

@tmancey tmancey requested review from goodov and iefremov November 19, 2024 19:55
@tmancey tmancey force-pushed the BraveAdsRedeemRewardConfirmationStudy branch 3 times, most recently from caa303c to 1832e90 Compare November 19, 2024 22:12
@tmancey tmancey requested a review from a team as a code owner November 19, 2024 22:12
@tmancey tmancey force-pushed the BraveAdsRedeemRewardConfirmationStudy branch from 1832e90 to cb81541 Compare November 19, 2024 22:36
@btlechowski
Copy link

btlechowski commented Nov 20, 2024 •
edited
Loading

Verified on

Brave 1.73.91 Chromium: 131.0.6778.85 (Official Build) (64-bit)
Revision 35427fa72a008a7e861fa9828e07a0ba2cd46ebd
OS Linux

Verified the study is enabled
image

Verified the fetch is 3s

[9279:9279:1120/170720.378798:VERBOSE1:redeem_reward_confirmation.cc(123)] Fetch payment token in 3 s

Verification passed on Brave v1.73.91 on Lenovo TB-8506FS (Android 11.0)

Verified the study is enabled

image

Verified the fetch is 3s

18:15:15.188  V  [VERBOSE1:redeem_reward_confirmation.cc(123)] Fetch payment token in 3 s

Verification passed on 1.75.36 on iPhone 13 Pro Max (iOS 17.7)

Verified the fetch is 3s

info	19:25:52.563597+0100	Client	[ads] Fetch payment token in 3 s

kjozwiak
kjozwiak approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers. QA has verified the PR as per #1265 (comment).

@kjozwiak kjozwiak added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 3f0ddf4 Nov 20, 2024
6 checks passed
@kjozwiak kjozwiak deleted the BraveAdsRedeemRewardConfirmationStudy branch November 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@goodov goodov Awaiting requested review from goodov

@iefremov iefremov Awaiting requested review from iefremov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @btlechowski @kjozwiak